Aws bedrock reranker #3652
Aws bedrock reranker #3652
Conversation
# Conflicts: # docs/components/rerankers/config.mdx # docs/components/rerankers/overview.mdx # mem0/configs/rerankers/base.py # mem0/utils/factory.py
There was a problem hiding this comment.
Please remove this examples file.
There was a problem hiding this comment.
Please match the writing style similar to here:
| print(results) | ||
| ``` | ||
|
|
||
| ## Prerequisites |
There was a problem hiding this comment.
You can remove the section for the aws account setup, it's too textual and these steps shouldn't be documented here.
| "api_key": "your-openai-key" | ||
| } | ||
| }, | ||
| "reranker": { |
There was a problem hiding this comment.
Can you change reranker to rerank to make it align with the code base?
| #### 4. IAM Roles (for EC2/Lambda) | ||
| ```python | ||
| config = { | ||
| "reranker": { |
There was a problem hiding this comment.
Same for the reranker here as well.
| ) | ||
|
|
||
| # Initialize reranker if configured | ||
| self.reranker = None |
There was a problem hiding this comment.
Duplicate code here as well.
| if threshold is None or mem.score >= threshold: | ||
| original_memories.append(memory_item_dict) | ||
|
|
||
| # Apply reranking if configured |
There was a problem hiding this comment.
Remove this code we have it's implementation in the search this becomes redundant.
| if threshold is None or mem.score >= threshold: | ||
| original_memories.append(memory_item_dict) | ||
|
|
||
| # Apply reranking if configured |
There was a problem hiding this comment.
same thing applies here.
| except (ImportError, AttributeError) as e: | ||
| raise ImportError(f"Could not import reranker for provider '{provider_name}': {e}") | ||
|
|
||
| # For AWS Bedrock, tests expect the factory to pass a plain dict to the reranker |
There was a problem hiding this comment.
Nit picking here, for the tests to pass we should update the tests and not code here, why are we explicitly handling aws bedrock config here?
| @@ -0,0 +1 @@ | |||
| """Tests for reranker implementations.""" | |||
There was a problem hiding this comment.
remove this as well.
2 participants
Description
Added AWS Bedrock as a reranker provider in the docs:
Added code changes to support AWS Bedrock reranker.
Fixes #3501
Type of change
Please delete options that are not relevant.
New feature (non-breaking change which adds functionality)
Documentation update
How Has This Been Tested?
make buildensures code builds properly.Checklist:
Maintainer Checklist