Fix embedchain Gmail loader test #3623
Open
+41
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the skipped Gmail loader test that was failing due to googleapiclient import issues.
Changes
@pytest.mark.skipdecorator fromtest_load_dataGmailReaderclass and its methodsBeautifulSoupmock to return proper string values instead of MagicMock objectsProblem
The Gmail loader test was being skipped with a TODO comment: "Fix this test. Failing due to some googleapiclient import issue." This prevented proper testing of the Gmail loader functionality.
Solution
Instead of skipping the test, properly mock the dependencies:
GmailReaderclass to avoid actual Google API callsBeautifulSoupparser to return proper string contentTesting
All tests pass successfully:
test_load_data_file_not_foundtest_load_dataImpact