Skip to content

Conversation

@StageGuard
Copy link
Member

@Karlatemp Karlatemp added this to the 2.16.0-RC milestone Jul 26, 2023
Copy link
Member

@Him188 Him188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好了叫我再 review 以下 (request review)

Comment on lines 48 to 50
@Serializable
@SerialName("FullyMessageIdentity")
public class RawFullyMessageIdentity(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@Serializable
@SerialName("FullyMessageIdentity")
public class RawFullyMessageIdentity(
@Serializable
@SerialName("FullMessageIdentity")
public class RawFullMessageIdentity(
* https://github.com/mamoe/mirai/blob/dev/LICENSE
*/

package net.mamoe.mirai.message.source
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

换个包? net.mamoe.mirai.message.source.identity

* https://github.com/mamoe/mirai/blob/dev/LICENSE
*/

package net.mamoe.mirai.message.source
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

换个包?

/**
* 用于定位消息的消息凭证符, 附带发送者 id 和消息类型
*
* @since 2.16.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不用标 .0,因为 patch 版本不会加新东西

@NotStableForInheritance
@ApiStatus.NonExtendable
@Serializable(FullyMessageIdentitySerializer::class)
public interface FullyMessageIdentity : MessageIdentity {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public interface FullyMessageIdentity : MessageIdentity {
public interface FullMessageIdentity : MessageIdentity {
@Him188 Him188 added the s:core 子系统: mirai-core label Jul 29, 2023
@Him188 Him188 modified the milestones: 2.16.0-RC, 2.17.0-RC Aug 24, 2023
@StageGuard
Copy link
Member Author

@Him188 2.16 准备发了?怎么移到 2.17 了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

s:core 子系统: mirai-core

4 participants