feat: allow changing property type #12047

tiensonqin · 2025-08-12T05:13:25Z

This PR allows to change user property's type to any other type.

How it works:
Changing property type will create a new property and mark the old one as deprecated.
It also remove old property kvs, history blocks and value blocks that're not pages or closed values.

New property:
:logseq.property/deprecated?

add unit tests
add e2e tests
test with rtc
add rtc e2e test @RCmerci

Screenshot:

RCmerci · 2025-08-13T15:39:40Z

@tiensonqin l'll add rtc e2e tests soon (tomorrow)

Copilot

Pull Request Overview

This PR introduces functionality to allow changing property types by creating a new property when the type changes and marking the old property as deprecated. The feature ensures data integrity by removing old property values while preserving pages and closed values, and includes a new :logseq.property/deprecated? property to track deprecated properties.

Adds property type change functionality that creates new properties instead of modifying existing ones
Implements property deprecation system with cleanup of old property data
Updates UI to handle deprecated properties and provide appropriate visual indicators

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`deps/outliner/src/logseq/outliner/property.cljs`	Core logic for property type changes, creating new properties and deprecating old ones
`deps/db/src/logseq/db/frontend/property.cljs`	Adds deprecated property detection function
`src/main/frontend/components/property/config.cljs`	Updates property configuration UI to handle type changes
`src/main/frontend/components/property.cljs`	Filters deprecated properties from display
`src/main/frontend/components/page.cljs`	Shows deprecation warning on property pages
`deps/db/src/logseq/db/frontend/db.cljs`	Excludes deprecated properties from all properties queries
`src/main/frontend/worker/search.cljs`	Excludes deprecated properties from search indexing
`src/main/frontend/worker/embedding.cljs`	Excludes deprecated properties from embedding
`deps/outliner/test/logseq/outliner/property_test.cljs`	Updates tests for new property type change behavior
`clj-e2e/test/logseq/e2e/property_basic_test.clj`	Adds E2E tests for property type changes

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-14T05:18:52Z

deps/outliner/src/logseq/outliner/property.cljs

-                      (parse-double v)
-                      v)]
-        (find-or-create-property-value conn property-id v')))))
+  (if (= :logseq.property/empty-placeholder v)


[nitpick] The early return for :logseq.property/empty-placeholder should be properly indented and the rest of the function body should be wrapped in the else clause for better readability.

Copilot · 2025-08-14T05:18:52Z

clj-e2e/src/logseq/e2e/util.clj

  (exit-edit)
-  (when (w/visible? "div[data-radix-popper-content-wrapper]")
+  (when (.isVisible (.first (w/-query "div[data-radix-popper-content-wrapper]")))
    (k/esc)))


Using .first on a query result without checking if the collection is empty could throw an exception. The original w/visible? function likely handles empty collections safely.

Copilot · 2025-08-14T05:18:52Z

clj-e2e/src/logseq/e2e/util.clj

    (k/esc))
  (exit-edit)
-  (when (w/visible? "div[data-radix-popper-content-wrapper]")
+  (when (.isVisible (.first (w/-query "div[data-radix-popper-content-wrapper]")))


Using .first on a query result without checking if the collection is empty could throw an exception. The original w/visible? function likely handles empty collections safely.

logseq-cldwalker

@tiensonqin Great to see users will be able to change the property type. Only had time to skim code so left some comments. Also one question: Is there a way for us to debug the previous idents of a property type change? Could be useful to have if these changes cause bugs later or if users want to know how their property has changed

logseq-cldwalker · 2025-08-14T16:23:42Z

deps/outliner/src/logseq/outliner/property.cljs

               (assoc :db/valueType :db.type/ref))]
      (and new-type old-ref-type? (not ref-type?))
      (conj [:db/retract (:db/id property) :db/valueType]))))



There's a lot of change in this heavily used ns which could cause critical bugs. Would be nice if more of it was tested e.g. retraction. I could try to do this next week if no one else does

logseq-cldwalker · 2025-08-14T16:27:39Z

deps/db/src/logseq/db/frontend/property.cljs

     :logseq.property/public? {:title "Property public?"
                               :schema {:type :checkbox
                                        :hide? true}}
+     :logseq.property/deprecated? {:title "Property already deprecated?"


Suggested change

:logseq.property/deprecated? {:title "Property already deprecated?"

:logseq.property/deprecated? {:title "Property deprecated?"

logseq-cldwalker · 2025-08-14T16:27:59Z

deps/db/src/logseq/db/frontend/property.cljs

             (get-in built-in-properties [db-ident :schema :type])))
+
+(defn deprecated?
+  "Whether the property has been deprecated"


Could this be used later for deprecating other built-in entities like pages or classes? If so, it would be worth generalizing the description and arg

logseq-cldwalker · 2025-08-14T16:29:39Z

deps/db/src/logseq/db/frontend/entity_util.cljs

       (when (or (map? page) (de/entity? page))
-         (:logseq.property/hide? page))))))
+         (or (:logseq.property/hide? page)
+             (:logseq.property/deprecated? page)))))))


Would be worth grepping all uses of :logseq.property/hide? and see if deprecated? belongs there as well

logseq-cldwalker · 2025-08-14T16:41:38Z

src/main/frontend/components/property/config.cljs

+                               (route-handler/redirect-to-page! (:block/uuid new-property)))
+                             ;; set value to empty
+                             (when owner-block
+                               (db-property-handler/set-block-property! (:db/id owner-block) (:db/ident new-property)


When the property type changes, what happens to all previous uses of the property? Do they become read-only or deleted? Do the results of some property queries change? Could be useful to display a confirmation dialog explaining what will happen so users understand and confirm they want the change

RCmerci · 2025-08-15T15:08:18Z

I tested some behaviors related to this PR and found some issues:

Currently, it supports changing the attribute type both in the 'configure on the property page and where the attribute is used.
We should only support changing the attribute type on the property page.
Changing the type where the attribute is used is prone to errors.
After changing the type in the property page's 'configure', previous instances of the attribute disappear(?), the expected behavior should be that the previous instances of the attribute are displayed as deprecated, right?

github-actions bot added the :type/enhancement Enhancement to product. Does not affect the overall basic use. label Aug 12, 2025

tiensonqin added 3 commits August 13, 2025 16:48

add property :logseq.property/deprecated?

0899ad5

enhance: allow changing property type after created

d93a456

hide deprecated properties from ui

70af283

tiensonqin force-pushed the enhance/change-property-type branch from d9279b9 to 70af283 Compare August 13, 2025 08:48

tiensonqin added 6 commits August 13, 2025 16:56

add tests for changing property type

af032a0

fix: changing property type in a block

015c668

add e2e tests

d174b96

fix: remove deprecated properties from search result

3b36821

fix: cleanup property history and values when changing type

a96e103

fix: lint

a0f5c05

tiensonqin marked this pull request as ready for review August 13, 2025 14:45

tiensonqin requested a review from Copilot August 13, 2025 14:46

tiensonqin changed the title ~~[WIP] feat: allow changing property type~~ Aug 13, 2025

tiensonqin requested review from RCmerci and logseq-cldwalker August 13, 2025 15:00

Merge branch 'master' into enhance/change-property-type

99bf0eb

This comment was marked as outdated.

Sign in to view

Merge branch 'master' into enhance/change-property-type

6c2b2ab

tiensonqin requested a review from Copilot August 14, 2025 05:17

Copilot AI reviewed Aug 14, 2025

View reviewed changes

logseq-cldwalker reviewed Aug 14, 2025

View reviewed changes

test(rtc): add change-property-type test

e3b90a0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: allow changing property type #12047

feat: allow changing property type #12047

tiensonqin commented Aug 12, 2025 •

edited by RCmerci

Loading

RCmerci commented Aug 13, 2025

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Copilot AI Aug 14, 2025

Copilot AI Aug 14, 2025

Copilot AI Aug 14, 2025

logseq-cldwalker left a comment •

edited

Loading

logseq-cldwalker Aug 14, 2025 •

edited

Loading

logseq-cldwalker Aug 14, 2025

logseq-cldwalker Aug 14, 2025

logseq-cldwalker Aug 14, 2025

logseq-cldwalker Aug 14, 2025

RCmerci commented Aug 15, 2025

Labels

4 participants

	:logseq.property/deprecated? {:title "Property already deprecated?"
	:logseq.property/deprecated? {:title "Property deprecated?"

Uh oh!

feat: allow changing property type #12047

Are you sure you want to change the base?

feat: allow changing property type #12047

Conversation

tiensonqin commented Aug 12, 2025 • edited by RCmerci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

RCmerci commented Aug 13, 2025

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

logseq-cldwalker left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

logseq-cldwalker Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

logseq-cldwalker Aug 14, 2025

Choose a reason for hiding this comment

logseq-cldwalker Aug 14, 2025

Choose a reason for hiding this comment

logseq-cldwalker Aug 14, 2025

Choose a reason for hiding this comment

logseq-cldwalker Aug 14, 2025

Choose a reason for hiding this comment

RCmerci commented Aug 15, 2025

Labels

4 participants

tiensonqin commented Aug 12, 2025 •

edited by RCmerci

Loading

logseq-cldwalker left a comment •

edited

Loading

logseq-cldwalker Aug 14, 2025 •

edited

Loading