Skip to content

Conversation

@mayooot
Copy link
Contributor

@mayooot mayooot commented Aug 23, 2025

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #2952

@mayooot mayooot requested a review from a team as a code owner August 23, 2025 06:17
@cbron cbron requested a review from nprokopic September 5, 2025 23:59
Copy link
Contributor

@nprokopic nprokopic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mayooot thank you for your contribution here! Also apologies for the late review.

chart/values.yaml is auto-generated. Unfortunately this is not clear, we will fix that.

Please add additionalSecrets to config/values.yaml here:

exportKubeConfig:

And then run go run hack/schema/main.go in the repo. This will then update chart/values.yaml.

Signed-off-by: Harry Li <harrymingh@gmail.com>
@mayooot
Copy link
Contributor Author

mayooot commented Oct 29, 2025

@mayooot thank you for your contribution here! Also apologies for the late review.

chart/values.yaml is auto-generated. Unfortunately this is not clear, we will fix that.

Please add additionalSecrets to config/values.yaml here:

exportKubeConfig:

And then run go run hack/schema/main.go in the repo. This will then update chart/values.yaml.

Thanks for your help. That's not your fault - I forget to update config/values.yaml. Please review the latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants