Chore: Testing: Add test coverage (MC/DC) for Note.mustHandleConflict #13593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a unit test suite for the
Note.mustHandleConflictmethod (located inpackages/lib/models/Note.ts), which previously had no dedicated test coverage.What this PR does:
This PR follows the contribution guidelines by adding automated tests for existing business logic.
The
mustHandleConflictmethod is responsible for critical business logic during synchronization, deciding when a note conflict should be created. The lack of tests represented a risk of regression.Explanation of Changes:
NoteConflict.test.js) to ensure compatibility with the@joplin/libsub-package's test environment.Manual Testing Plan (for the reviewer):
While the automated tests validate the logic, the following manual steps can be used to confirm execution:
Verify Test Execution:
Verify Coverage: