Docs: Resolves #13591: Update terminal.md (readme) to mention 'z' shortcut #13592
Conversation
Added mention of `z` shortcut for `toggle_folder_collapse` to the documentation for the terminal application. Said command is mentioned in `:help keymaps` but not currently here. This is my first time committing to a public repository, so I apologize if I make a mistake.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
HarmonicSoldier
changed the title
Thank you for the fix! I've committed you're update. Co-authored-by: Henry Heino <46334387+personalizedrefrigerator@users.noreply.github.com>
| delete | Deletes the selected item | ||
| toggle_console | Toggle the console | ||
| toggle_metadata | Toggle note metadata | ||
| toggle_folder_collapse | Toggle display of sub-notebooks of current notebook in the notebooks pane |
There was a problem hiding this comment.
That's a lot of repetitions and I don't think it's grammatically correct. Maybe just "Expand or collapse the notebooks"?
| mb mkbook "" | ||
| yn cp $n "" | ||
| dn mv $n "" | ||
| z toggle_folder_collapse |
There was a problem hiding this comment.
How about updating the complete list based on defaultKeyMap from app.ts?
| { "keys": ["yn"], "type": "prompt", "command": "cp $n \"\"", "cursorPosition": -2 }, | ||
| { "keys": ["dn"], "type": "prompt", "command": "mv $n \"\"", "cursorPosition": -2 } | ||
| { "keys": ["dn"], "type": "prompt", "command": "mv $n \"\"", "cursorPosition": -2 }, | ||
| { "keys": ["z"], "command": "toggle_folder_collapse" } |
There was a problem hiding this comment.
Same here. If we're going to update this we may as well update all that's missing
There was a problem hiding this comment.
Thank you for the feedback. On further examination, it seems like there are at least a few other shortcuts missing from the documentation, such as ti. I'll spend the coming week finding whatever may be missing and writing concise description of them in the documentation. I will update the issue I posted to accommodate.
3 participants
Added mention of
zshortcut fortoggle_folder_collapseto the documentation for the terminal application. Said command is mentioned in:help keymapsbut not currently here.This is my first time making a pull request, so I apologize if I made a faux paux anywhere.