KTOR-3194 - enable customize default tags in micrometer #2874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OR-3194 � Conflicts: � ktor-features/ktor-metrics-micrometer/jvm/src/io/ktor/metrics/micrometer/MicrometerMetrics.kt � ktor-server/ktor-server-plugins/ktor-server-metrics-micrometer/jvm/test/io/ktor/server/metrics/micrometer/MicrometerMetricsTests.kt
e5l
force-pushed
the
main
branch
2 times, most recently
from
d084312 to
1ae2c1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Ktor-metrics-micrometer
Motivation
Feature: https://youtrack.jetbrains.com/issue/KTOR-3194
Sometimes you need to override default tags and the only way was using this sentence in MicrometerMetrics installation:
metrics.config().meterFilter(MeterFilter.ignoreTags($tag))
Solution
I've created a default tags field which allows to be overwritten in the configuration class.
Some fields/classes have to be internal in order to allow the client to access and customize tags using the call.