ci: fix test workflow triggers and acknowledge test warnings #2202
+61
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only run tests when relevant files change (src/, tests/, uv.lock, pyproject.toml, .github/workflows/) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- deprecation warning for sse_app method in test_sse.py - in-memory token storage warning in oauth client tests instead of suppressing warnings in pytest config, explicitly assert that expected warnings are raised. this validates that the warnings are working as intended. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
add pytest.warns assertions for remaining OAuth tests that trigger the in-memory token storage warning in test_client.py and test_mcp_config.py 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
marvin-context-protocol
bot
added
enhancement
There was a problem hiding this comment.
Pull Request Overview
This PR improves CI efficiency and test quality by filtering test runs to relevant file changes and explicitly validating expected warnings instead of suppressing them. The changes ensure warnings are intentionally tested and documented, confirming they work as designed.
Key changes:
- Added path filters to the GitHub Actions workflow to skip test runs on documentation-only changes
- Converted warning suppressions to explicit
pytest.warns()assertions for deprecation and security warnings
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/run-tests.yml |
Added path filters to only trigger tests on source, test, or configuration changes |
tests/client/test_sse.py |
Added explicit assertion for sse_app() deprecation warning |
tests/client/test_client.py |
Added explicit assertions for in-memory OAuth token storage warnings across multiple test cases |
tests/client/auth/test_oauth_client.py |
Added explicit assertion for in-memory token storage warning in fixture |
tests/test_mcp_config.py |
Added explicit assertion for in-memory token storage warning in config test |
jlowin
reviewed
Oct 26, 2025
| - "pyproject.toml" | ||
| - ".github/workflows/**" | ||
|
|
||
| # run on all pull requests because these checks are required and will block merges otherwise |
There was a problem hiding this comment.
@zzstoatzz the issue is that if someone opens a doc PR, these tests wont run and they're required to pass in order to merge (I can override, and do, but i wish there was a better way)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only run unit/integration tests on library/test/ci changes and fix warnings
ai yap summary
Changes
CI Workflow
Added
pathsfilter topull_requesttrigger in.github/workflows/run-tests.ymlso tests only run when:src/**tests/**uv.lockpyproject.toml.github/workflows/**This prevents unnecessary test runs on PRs that only touch examples or documentation.
Test Warnings
Replaced warning suppression with explicit assertions using
pytest.warns():Deprecation warning for
server.sse_app()intests/client/test_sse.pyUserWarning for in-memory token storage in OAuth tests:
tests/client/auth/test_oauth_client.pytests/client/test_client.pytests/test_mcp_config.pyThese changes ensure warnings are intentionally tested rather than silently suppressed, confirming they work as designed.
🤖 Generated with Claude Code