Skip to content

Show placeholder thumbnail while Trickplay thumbnail loads #4946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Show placeholder thumbnail while Trickplay thumbnail loads #4946

wants to merge 2 commits into from

Conversation

@tal-sarid
Copy link
Contributor

Changes
Introducing a placeholder thumbnail that is displayed while the actual Trickplay thumbnail is being loaded. This provides visual feedback to the user and improves the perceived performance of Trickplay seeking.

The placeholder is a simple black transparent bitmap matching the dimensions of the expected thumbnail and it is cached to avoid redundant creations and memory allocations.
@tal-sarid
Copy link
Contributor Author

I also explained here why it is OK to call onThumbnailLoaded twice for the same index.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@tal-sarid