Skip to content

feat(float-layout): 增加参数top,类型为Booolean,默认值为false,控制浮动弹层是否顶部弹出 #738 #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat(float-layout): 增加参数top,类型为Booolean,默认值为false,控制浮动弹层是否顶部弹出 #738 #746

wants to merge 1 commit into from

Conversation

@AnOrdinaryMan
Copy link

@AnOrdinaryMan AnOrdinaryMan commented Aug 18, 2019 •
edited
Loading

@AnOrdinaryMan AnOrdinaryMan mentioned this pull request Aug 18, 2019
Open
@AnOrdinaryMan AnOrdinaryMan changed the title feat(float-layout): 增加参数top,类型为Booolean,默认值为false,控制浮动弹层是否顶部弹出 NervJS#738 Aug 18, 2019
@koppthe
Copy link
Collaborator

koppthe commented Aug 22, 2019

这块单独抽离一个 Popup 组件是不是更合适一些呢？
FloatLayout 是根据 Taro UI 的视觉规范做的组件，固定以底部弹出的交互形式。
@AnOrdinaryMan
Copy link
Author

这块单独抽离一个 Popup 组件是不是更合适一些呢？
FloatLayout 是根据 Taro UI 的视觉规范做的组件，固定以底部弹出的交互形式。

这里仅仅是改变了弹出的位���，需要因此单独抽离为一个组件吗
@koppthe
Copy link
Collaborator

koppthe commented Aug 23, 2019

抽离一个 Popup 组件更合理一些，FloatLayout 的交互规范不能更改哈
@kapbook-caizhehao
Copy link

请问该功能是否已实现
@AnOrdinaryMan
Copy link
Author

请问该功能是否已实现

如上，官方建议抽离成一个Popup组件，未采纳PR
@kapbook-caizhehao
Copy link

请问该功能是否已实现

如上，官方建议抽离成一个Popup组件，未采纳PR
我是说floatlayout从上而下弹出的功能是否已融合到最新版本
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@AnOrdinaryMan @koppthe @kapbook-caizhehao