ed25519: canonical enc/dec, hash binding, and subgroup checks #337
+213
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 1 —
decodePoint: enforce 32 bytes; rejecty ≥ pRequire exactly 32 bytes, clear the MSB to recover
y, and fail if the resultingyis ≥ field primep. Ensures strict, non-malleable decoding. Ref: RFC 8032 §5.1.3.Fix 2 —
verify: bind hash to actual pointsRe-encode
RandAfrom the decoded points for the challenge hash instead of trusting attacker-controlledRencoded()/pubBytes(). Prevents verification confusion/object spoofing.Fix 3 —
verify: enforce subgroup membershipReject identity or small-order
A/Rby checkingP * n == ∞. Closes cofactor-related attacks that can yield bogus verifications in multi-sig/aggregation flows.Also add some tests.