Skip to content

Gold refactor #4373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 45 commits into
base: main
Choose a base branch
from
Draft

Gold refactor #4373

wants to merge 45 commits into from
+478 −347

Conversation

@qgallouedec
Copy link
Member

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
kashif and others added 30 commits October 27, 2025 20:06
@kashif
intial
c3e4744
@kashif
initial tests
1966d1f
@kashif
add test_uldloss_hybrid_config_beta_zero
59bef64
@kashif
update sleep mode
954aa88
@kashif
Merge branch 'main' into gold
f8b7212
@kashif
chatml test and docs
007f80a
@kashif
fix formatting and mark heavier tests as slow
406d3ed
@kashif
edge case when student/teacher have no overlap in hybrid loss
d2f4e6b
@kashif
typos
0ed3b34
@qgallouedec
style in doc
05a044c
@qgallouedec
citation as class attr
b32acf6
@kashif
use student_model_revision
9fde612
@kashif
Dropped the deprecated formatting_func
5bcd11f
@kashif
use _set_signature_columns_if_needed
be88e8e
@kashif
Removed the dataset_kwargs["skip_prepare_dataset"] hack
bae7df5
@kashif
use create_model_from_path helper
e141e52
@kashif
better names
7871dfd
@kashif
moved imports to top level
dfb1310
@kashif
remove student_ prefix from vllm configs
624ec4c
@kashif @qgallouedec
Update trl/experimental/gold/gold_config.py
7061253 
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
@kashif @qgallouedec
Update trl/experimental/gold/gold_trainer.py
e36a11c 
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
@kashif
use max_completion_length
9acf7eb
@kashif
use relative imports
4e69b12
@kashif
avoid hasattr
62f18e8
@kashif
use ensure_master_addr_port
a2acc33
@kashif @qgallouedec
Update trl/experimental/gold/gold_trainer.py
aab8b02 
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
@kashif @qgallouedec
Update trl/experimental/gold/gold_trainer.py
e2dfff5 
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
@kashif
minimal example
0a0c79a
@kashif
remove padding when calling generate_batch
cb587c2
@kashif
use lightweight _GoldDataCollator
3382b1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@qgallouedec @kashif