[DEV-4322] HelloSign Embedded v2 - #80
Merged
Merged
Conversation
refactor(DEV-4322): HelloSign Embedded v2 BREAKING CHANGE: `HelloSign` is now a class, not a singleton. BREAKING CHANGE: `init()` has been deprecated BREAKING CHANGE: The `url` option is now the first argument of `open()` BREAKING CHANGE: `open()` options are now defined as the second argument BREAKING CHANGE: `userCulture` option is now named `locale` BREAKING CHANGE: `healthCheckoutTimeoutMs` option is now named `timeout` BREAKING CHANGE: `requester` option is now named `requestingEmail` BREAKING CHANGE: `messageListener` option has been removed BREAKING CHANGE: `uxVersion` option has been removed BREAKING CHANGE: `height` option has been removed BREAKING CHANGE: `HelloSign.CULTURES` is now `HelloSign.locales` BREAKING CHANGE: `HelloSign.VERSION` is now `HelloSign.version` Fixes #27, fixes #31, fixes #36, fixes #40, fixes #47, fixes #57, fixes #75.
HelloSign Embedded will now be available at cdn.hellosign.com/embedded/
nathanbuchar
added a commit
that referenced
this pull request
Oct 10, 2018
* [DEV-4322] HelloSign Embedded v2 (#80) refactor(DEV-4322): HelloSign Embedded v2 BREAKING CHANGE: `HelloSign` is now a class, not a singleton. BREAKING CHANGE: `init()` has been deprecated BREAKING CHANGE: The `url` option is now the first argument of `open()` BREAKING CHANGE: `open()` options are now defined as the second argument BREAKING CHANGE: `userCulture` option is now named `locale` BREAKING CHANGE: `healthCheckoutTimeoutMs` option is now named `timeout` BREAKING CHANGE: `requester` option is now named `requestingEmail` BREAKING CHANGE: `messageListener` option has been removed BREAKING CHANGE: `uxVersion` option has been removed BREAKING CHANGE: `height` option has been removed BREAKING CHANGE: `HelloSign.CULTURES` is now `HelloSign.locales` BREAKING CHANGE: `HelloSign.VERSION` is now `HelloSign.version` Fixes #27, fixes #31, fixes #36, fixes #40, fixes #47, fixes #57, fixes #75. * chore(release): 2.0.0
nathanbuchar
added a commit
that referenced
this pull request
Oct 10, 2018
* [DEV-4322] HelloSign Embedded v2 (#80) refactor(DEV-4322): HelloSign Embedded v2 BREAKING CHANGE: `HelloSign` is now a class, not a singleton. BREAKING CHANGE: `init()` has been deprecated BREAKING CHANGE: The `url` option is now the first argument of `open()` BREAKING CHANGE: `open()` options are now defined as the second argument BREAKING CHANGE: `userCulture` option is now named `locale` BREAKING CHANGE: `healthCheckoutTimeoutMs` option is now named `timeout` BREAKING CHANGE: `requester` option is now named `requestingEmail` BREAKING CHANGE: `messageListener` option has been removed BREAKING CHANGE: `uxVersion` option has been removed BREAKING CHANGE: `height` option has been removed BREAKING CHANGE: `HelloSign.CULTURES` is now `HelloSign.locales` BREAKING CHANGE: `HelloSign.VERSION` is now `HelloSign.version` Fixes #27, fixes #31, fixes #36, fixes #40, fixes #47, fixes #57, fixes #75. * chore(DEV-4322): Update Travis CI S3 upload directory * chore(release): 2.0.0
nathanbuchar
added a commit
that referenced
this pull request
Oct 11, 2018
* [DEV-4322] HelloSign Embedded v2 (#80) refactor(DEV-4322): HelloSign Embedded v2 BREAKING CHANGE: `HelloSign` is now a class, not a singleton. BREAKING CHANGE: `init()` has been deprecated BREAKING CHANGE: The `url` option is now the first argument of `open()` BREAKING CHANGE: `open()` options are now defined as the second argument BREAKING CHANGE: `userCulture` option is now named `locale` BREAKING CHANGE: `healthCheckoutTimeoutMs` option is now named `timeout` BREAKING CHANGE: `requester` option is now named `requestingEmail` BREAKING CHANGE: `messageListener` option has been removed BREAKING CHANGE: `uxVersion` option has been removed BREAKING CHANGE: `height` option has been removed BREAKING CHANGE: `HelloSign.CULTURES` is now `HelloSign.locales` BREAKING CHANGE: `HelloSign.VERSION` is now `HelloSign.version` Fixes #27, fixes #31, fixes #36, fixes #40, fixes #47, fixes #57, fixes #75. * chore(DEV-4322): Update Travis CI S3 upload directory * chore(release): 2.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.