Skip to content

Commit 35c0566

Browse files
committed
1 parent c74ea84 commit 35c0566

File tree

7 files changed

+5
-14
lines changed

7 files changed

+5
-14
lines changed

‎chain/ethereum/src/ethereum_adapter.rs

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -113,21 +113,12 @@ impl EthereumAdapter {
113113
) -> Self {
114114
let web3 = Arc::new(Web3::new(transport));
115115

116-
// Use the client version to check if it is ganache. For compatibility with unit tests, be
117-
// are lenient with errors, defaulting to false.
118-
let is_ganache = web3
119-
.web3()
120-
.client_version()
121-
.await
122-
.map(|s| s.contains("TestRPC"))
123-
.unwrap_or(false);
124-
125116
EthereumAdapter {
126117
logger,
127118
provider,
128119
web3,
129120
metrics: provider_metrics,
130-
supports_eip_1898: supports_eip_1898 && !is_ganache,
121+
supports_eip_1898,
131122
call_only,
132123
supports_block_receipts: Arc::new(RwLock::new(None)),
133124
}

‎tests/integration-tests/ganache-reverts/package.json renamed to ‎tests/integration-tests/reverted-calls/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
2-
"name": "ganache-reverts",
3-
"version": "0.1.0",
2+
"name": "reverted-calls",
3+
"version": "0.1.1",
44
"scripts": {
55
"build-contracts": "../../common/build-contracts.sh",
66
"codegen": "graph codegen --skip-migrations",

‎tests/tests/integration_tests.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -657,7 +657,7 @@ async fn test_topic_filters(ctx: TestContext) -> anyhow::Result<()> {
657657
Ok(())
658658
}
659659

660-
async fn test_ganache_reverts(ctx: TestContext) -> anyhow::Result<()> {
660+
async fn test_reverted_calls_are_indexed(ctx: TestContext) -> anyhow::Result<()> {
661661
let subgraph = ctx.subgraph;
662662
assert!(subgraph.healthy);
663663

@@ -1028,7 +1028,7 @@ async fn integration_tests() -> anyhow::Result<()> {
10281028
let test_name_to_run = std::env::var("TEST_CASE").ok();
10291029

10301030
let cases = vec![
1031-
TestCase::new("ganache-reverts", test_ganache_reverts),
1031+
TestCase::new("reverted-calls", test_reverted_calls_are_indexed),
10321032
TestCase::new("host-exports", test_host_exports),
10331033
TestCase::new("non-fatal-errors", test_non_fatal_errors),
10341034
TestCase::new("overloaded-functions", test_overloaded_functions),

0 commit comments

Comments
 (0)