feat: Implement SQL support in test proxy#1106
feat: Implement SQL support in test proxy#1106daniel-sanche merged 5 commits intogoogleapis:mainfrom
Conversation
4dcd3dd to
eaae0f3
Compare
daniel-sanche
left a comment
There was a problem hiding this comment.
The changes mostly LGTM, but do you know why the tests are now failing? Is it because of the updated protos?
| # limitations under the License. | ||
| """ | ||
| This module contains helpers for handling sql data types for the test proxy. | ||
| """ |
There was a problem hiding this comment.
I think this should be outside of the handlers folder, and maybe renamed to something like sql_encoding_helpers.py
Or if putting it in a parent folder is tricky, you can make a handlers/helpers folder and put it in there
|
@jackdingilian Maybe for this PR we should just ignore the proto updates? Right now our conformance tests are locked on to tag Maybe for this PR, we should just focus on getting Let me know what you think |
9a8ce60 to
21d7771
Compare
daniel-sanche
left a comment
There was a problem hiding this comment.
LGTM
We will have to update the test tag for the sql tests to run, but that can come as a follow up
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕