Skip to content

fix: propagate set options to LeaseManager (from https://github.com/googleapis/nodejs-pubsub/pull/1880)#1954

Merged
gcf-merge-on-green[bot] merged 6 commits intogoogleapis:mainfrom
feywind:set
Aug 26, 2024
Merged

fix: propagate set options to LeaseManager (from https://github.com/googleapis/nodejs-pubsub/pull/1880)#1954
gcf-merge-on-green[bot] merged 6 commits intogoogleapis:mainfrom
feywind:set

Conversation

@feywind
Copy link
Collaborator

@feywind feywind commented Jul 10, 2024 •
edited
Loading

Bringing this over from #1880 (dermasmid@) so I can work CI on it.

Fixes #1879
@feywind feywind requested a review from a team as a code owner July 10, 2024 20:05
@feywind feywind requested a review from a team July 10, 2024 20:05
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Jul 10, 2024
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2024
@feywind feywind mentioned this pull request Jul 10, 2024
Closed
@feywind feywind changed the title fix: set MaxBytes for AckQueue (from https://github.com/googleapis/nodejs-pubsub/pull/1897) Jul 10, 2024
@feywind feywind changed the title fix: set MaxBytes for AckQueue (from https://github.com/googleapis/nodejs-pubsub/pull/1880) Jul 10, 2024
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2024
hongalex
hongalex reviewed Jul 25, 2024
View reviewed changes
src/subscriber.ts Outdated
);
}

if (this._acks) {
Copy link
Member

@hongalex hongalex Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not expose these settings more than they already are, since we don't want users to be able to set these batching settings. Flow control is ok though
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Aug 26, 2024
@feywind feywind added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 26, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 26, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit cdb0916 into googleapis:main Aug 26, 2024
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 26, 2024
@release-please release-please bot mentioned this pull request Aug 26, 2024
Merged
@feywind feywind deleted the set branch August 26, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: xs Pull request size is extra small.

3 participants

@feywind @hongalex @dermasmid