fix: update masks for topic should be snake case#1778
Merged
feywind merged 3 commits intogoogleapis:mainfrom Jul 26, 2023
Merged
fix: update masks for topic should be snake case#1778feywind merged 3 commits intogoogleapis:mainfrom
feywind merged 3 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
size: s
feywind
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
src/util.ts
Outdated
| * @private | ||
| */ | ||
| export function camelToSnake(input: string): string { | ||
| return input.replace(/[A-Z]/g, letter => `_${letter.toLowerCase()}`); |
Contributor
There was a problem hiding this comment.
It's good to double check what should happen with numbers. E. g. abc360Value - should it be abc_360_value or abc360_value? Ask me why I care :)
There was a problem hiding this comment.
I brought up in a 1-1 chat that I want to see a test so this would be a good test case too 😁
alexander-fenster
approved these changes
Jul 25, 2023
feywind
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
leahecole
approved these changes
Jul 26, 2023
feywind
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1587