Skip to content

fix: Deflake WaiterTest#2600

Merged
michaelpri10 merged 7 commits intogoogleapis:mainfrom
michaelpri10:waiter-test
Oct 21, 2025
Merged

fix: Deflake WaiterTest#2600
michaelpri10 merged 7 commits intogoogleapis:mainfrom
michaelpri10:waiter-test

Conversation

@michaelpri10
Copy link
Contributor

@michaelpri10 michaelpri10 commented Oct 21, 2025

Deflake the WaiterTest by adding more logic to ensure that the Waiter is waiting before we advance the clock.

Fixes #2596

@michaelpri10 michaelpri10 requested review from a team October 21, 2025 14:56
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/java-pubsub API. labels Oct 21, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 21, 2025
Copy link

@feywind feywind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting.

@michaelpri10 michaelpri10 merged commit 298c8db into googleapis:main Oct 21, 2025
153 of 155 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. size: s Pull request size is small.

3 participants