fix: Add retries for ack and modack operations that don't return with a metadata map#2385
Merged
michaelpri10 merged 3 commits intogoogleapis:mainfrom Mar 31, 2025
Merged
Conversation
product-auto-label
bot
added
size: m
hongalex
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds retries on ack and modack operations when the failure does not have a metadata map. This also adds a small change to only check ack IDs that are in a specific modack batch and adds a StatusUtil helper method. Additionally, we will forget ack IDs when an ack or modack fails with a non-retryable error.