Skip to content

feat: Support float32, float64, and array type query params#2297

Merged
jackdingilian merged 2 commits intogoogleapis:mainfrom
jackdingilian:add-array-params
Jul 31, 2024
Merged

feat: Support float32, float64, and array type query params#2297
jackdingilian merged 2 commits intogoogleapis:mainfrom
jackdingilian:add-array-params

Conversation

@jackdingilian
Copy link
Contributor

@jackdingilian jackdingilian commented Jul 26, 2024 •
edited
Loading

Also fixes a bug with float32 lists where it was incorrectly converted to List of Double where we expect List of Float

Change-Id: I4d4b32dcddef74711eeea8997b020c46eee8be3c

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.
@jackdingilian
feat: Support float32, float64, and array type query params
513d1df 
Also fixes a bug with float32 lists where it was incorrectly converted to List<Double> where we
expect List<Float>

Change-Id: I4d4b32dcddef74711eeea8997b020c46eee8be3c
@jackdingilian jackdingilian requested review from a team July 26, 2024 16:23
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Jul 26, 2024
@jackdingilian jackdingilian added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 26, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 26, 2024
@gcf-owl-bot gcf-owl-bot bot requested a review from a team July 26, 2024 17:10
tonytanger
tonytanger reviewed Jul 29, 2024
View reviewed changes
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/sql/Statement.java
private static ArrayValue arrayValueOf(List<?> value, SqlType.Array<?> arrayType) {
ArrayValue.Builder valueBuilder = ArrayValue.newBuilder();
for (Object element : value) {
if (element == null) {
Copy link
Contributor

@tonytanger tonytanger Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be of a nullValueWithType?
Copy link
Contributor Author

@jackdingilian jackdingilian Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the API only wants the type set on the outermost value, not nested elements
tonytanger
tonytanger reviewed Jul 29, 2024
View reviewed changes
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/sql/Statement.java
break;
case FLOAT64:
Double doubleElem = (Double) element;
valueBuilder.addValues(Value.newBuilder().setFloatValue(doubleElem).build());
Copy link
Contributor

@tonytanger tonytanger Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we float64ParamOf(doubleElm)?
Copy link
Contributor Author

@jackdingilian jackdingilian Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because we don't want to set type on the nested elements
@tonytanger
Copy link
Contributor

tonytanger commented Jul 29, 2024

LGTM
@jackdingilian jackdingilian merged commit a65640e into googleapis:main Jul 31, 2024
@jackdingilian jackdingilian deleted the add-array-params branch July 31, 2024 14:41
@release-please release-please bot mentioned this pull request Jul 31, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 6, 2024
@release-please
chore(main): release 2.42.0 (#2301)
715b7d0 
🤖 I have created a release *beep* *boop*
---


## [2.42.0](https://togithub.com/googleapis/java-bigtable/compare/v2.41.0...v2.42.0) (2024-08-06)


### Features

* Support float32, float64, and array type query params ([#2297](https://togithub.com/googleapis/java-bigtable/issues/2297)) ([a65640e](https://togithub.com/googleapis/java-bigtable/commit/a65640e285950d02136544bac913b2852cfe0274))


### Bug Fixes

* Adapt toString tests to introduction of java.time in gax  ([93f66a7](https://togithub.com/googleapis/java-bigtable/commit/93f66a70371f8095fd5c001a977d71e5622be46d))


### Dependencies

* Update shared dependencies ([93f66a7](https://togithub.com/googleapis/java-bigtable/commit/93f66a70371f8095fd5c001a977d71e5622be46d))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request Dec 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.

3 participants

@jackdingilian @tonytanger @igorbernstein2