feat: client sends routing cookie back to server by mutianf · Pull Request #1888 · googleapis/java-bigtable

mutianf · 2023-08-16T19:59:20Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

...e-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/CookieInterceptor.java

...le-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/CookieHolderTest.java

...e-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/CookieInterceptor.java

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/CookiesHolder.java

...ble/src/main/java/com/google/cloud/bigtable/data/v2/stub/CookiesServerStreamingCallable.java

...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/CookiesUnaryCallable.java

...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java

...le-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/CookieHolderTest.java

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/CookiesHolder.java

...-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/CookiesInterceptor.java

...e-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/CookiesHolderTest.java

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/CookiesHolder.java

...-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/CookiesInterceptor.java

...e-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/CookiesHolderTest.java

igorbernstein2 · 2023-11-21T20:12:42Z

...e-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/CookiesHolderTest.java

+    String bytes1 = serverMetadata.get(1).get(ROUTING_COOKIE_1);
+    String bytes2 = serverMetadata.get(1).get(ROUTING_COOKIE_2);
+    assertThat(bytes1).isNotNull();
+    assertThat(bytes1).isEqualTo("readRows");


assertThat(bytes1).isEqualTo("readRows"); should cover isNotNull

why get(1)? is that the last one? if so please make it explicit

Ideally you would add a MetadataSubject and then did something like this:

assertThat(serverMetadata).isNotEmpty(); Metadata lastMd = serverMetadata.get(serverMetadata.size() - 1); assertThat(serverMetadata.get(lastMd).containsAtLeast(ROUTING_COOKIE_1, "readRows", ROUTING_COOKIE_2, testCookieValue); assertThat(serverMetadata.get(lastMd).doesNotContainKey(BAD_KEY)

I don't think I can do assertThat(serverMetadata.get(lastMd).containsAtLeast(ROUTING_COOKIE_1, "readRows", ROUTING_COOKIE_2, testCookieValue); because metadata is not a map :( and I can't get the map out of it :(

with a custom subject you can

generated-files-bot · 2023-11-22T19:26:21Z

Warning: This pull request is touching the following templated files:

.kokoro/build.sh

...e-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/CookiesHolderTest.java

igorbernstein2

lgtm after the last set of comments

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

dbolduc · 2023-12-12T16:38:24Z

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/CookiesHolder.java

+import javax.annotation.Nullable;
+
+/** A cookie that holds information for retry or routing */
+class CookiesHolder {


I would have called this a CookieJar

product-auto-label bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Aug 16, 2023

mutianf added 2 commits October 17, 2023 14:06

feat: client sends retry cookie back to server

d274fc2

udpate to use trailer instead of error info

9333ba0

mutianf force-pushed the cookie branch from bfafcd3 to 9333ba0 Compare October 17, 2023 21:03

mutianf changed the title ~~feat: [POC] client sends retry cookie back to server~~ Oct 18, 2023

updating the header name

678bc35

igorbernstein2 requested changes Oct 23, 2023

View reviewed changes

...e-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/CookieInterceptor.java Outdated Show resolved Hide resolved

...le-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/CookieHolderTest.java Outdated Show resolved Hide resolved

mutianf marked this pull request as ready for review October 24, 2023 14:15

mutianf requested a review from a team October 24, 2023 14:15

mutianf added 3 commits November 6, 2023 15:57

address some comments

e6ab87f

udpate

ba373a7

update tests and handling of retry cookie

be27ca8

mutianf changed the title ~~feat: client sends retry cookie back to server~~ Nov 14, 2023

igorbernstein2 requested changes Nov 14, 2023

View reviewed changes

address comments

1fa268d

igorbernstein2 reviewed Nov 16, 2023

View reviewed changes

mutianf added 3 commits November 16, 2023 14:14

address comments

91989cd

add cookie to readChangeStream

1422950

also check headers and add a test

67779d5

igorbernstein2 reviewed Nov 17, 2023

View reviewed changes

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/CookiesHolder.java Outdated Show resolved Hide resolved

...-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/CookiesInterceptor.java Outdated Show resolved Hide resolved

simplify code

92f759e

igorbernstein2 reviewed Nov 21, 2023

View reviewed changes

mutianf added 3 commits November 21, 2023 15:52

clean up test

d49ce70

clean up test

6479464

update dependency

3b4c178

mutianf requested a review from a team November 22, 2023 18:16

test

abad657

move MetadataSubject to a separate file

9d9a429

mutianf added 2 commits November 22, 2023 14:47

add the file

660085b

add license

a0dd03d

igorbernstein2 reviewed Nov 22, 2023

View reviewed changes

...e-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/CookiesHolderTest.java Outdated Show resolved Hide resolved

igorbernstein2 reviewed Nov 22, 2023

View reviewed changes

...e-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/CookiesHolderTest.java Outdated Show resolved Hide resolved

igorbernstein2 reviewed Nov 22, 2023

View reviewed changes

...e-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/CookiesHolderTest.java Outdated Show resolved Hide resolved

igorbernstein2 reviewed Nov 22, 2023

View reviewed changes

...e-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/CookiesHolderTest.java Outdated Show resolved Hide resolved

igorbernstein2 approved these changes Nov 22, 2023

View reviewed changes

mutianf added 2 commits November 22, 2023 15:41

address comments

1aaaddc

close client

00eb5df

mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 22, 2023

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 22, 2023

gcf-owl-bot bot and others added 2 commits November 22, 2023 21:17

🦉 Updates from OwlBot post-processor

6a33c0a

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'main' into cookie

5927a64

mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 22, 2023

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 22, 2023

🦉 Updates from OwlBot post-processor

f76fac7

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

mutianf merged commit 4c73abd into googleapis:main Nov 27, 2023

mutianf deleted the cookie branch November 27, 2023 15:15

release-please bot mentioned this pull request Nov 27, 2023

chore(main): release 2.30.0 #2008

Merged

dbolduc reviewed Dec 12, 2023

View reviewed changes

bhshkh mentioned this pull request Aug 28, 2025

bigtable: support routing cookie googleapis/google-cloud-go#12658

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: client sends routing cookie back to server#1888

feat: client sends routing cookie back to server#1888
mutianf merged 23 commits intogoogleapis:mainfrom
mutianf:cookie

mutianf commented Aug 16, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

igorbernstein2 Nov 21, 2023

igorbernstein2 Nov 21, 2023

igorbernstein2 Nov 21, 2023

mutianf Nov 21, 2023

igorbernstein2 Nov 21, 2023 •

edited

Loading

generated-files-bot bot commented Nov 22, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

igorbernstein2 left a comment

dbolduc Dec 12, 2023

Labels

3 participants

Conversation

mutianf commented Aug 16, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

igorbernstein2 Nov 21, 2023

Choose a reason for hiding this comment

igorbernstein2 Nov 21, 2023

Choose a reason for hiding this comment

igorbernstein2 Nov 21, 2023

Choose a reason for hiding this comment

mutianf Nov 21, 2023

Choose a reason for hiding this comment

igorbernstein2 Nov 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

generated-files-bot bot commented Nov 22, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

igorbernstein2 left a comment

Choose a reason for hiding this comment

dbolduc Dec 12, 2023

Choose a reason for hiding this comment

Labels

3 participants

igorbernstein2 Nov 21, 2023 •

edited

Loading