Skip to content

fix: if new_partitions is size 0, do not enforce size check#1673

Merged
gcf-merge-on-green[bot] merged 1 commit intogoogleapis:mainfrom
tonytanger:remove_new_partitions_check
Mar 21, 2023
Merged

fix: if new_partitions is size 0, do not enforce size check#1673
gcf-merge-on-green[bot] merged 1 commit intogoogleapis:mainfrom
tonytanger:remove_new_partitions_check

Conversation

@tonytanger
Copy link
Contributor

@tonytanger tonytanger commented Mar 20, 2023

Do not enforce new_partitions and change_stream_continuation_tokens to be the same size if new_partitions has size of 0 because Cloud Bigtable backend may not be updated to serve new_partitions field yet.

new_partitions is a new field and the backend may not be serving this field.

Change-Id: Id21c293b92c304f05b905ca8e8b3988b9241866e

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.
@tonytanger tonytanger requested a review from a team March 20, 2023 20:14
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Mar 20, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Mar 20, 2023
@tonytanger tonytanger changed the title If new_partitions is size 0, do not enforce size check. Mar 20, 2023
@tonytanger
Copy link
Contributor Author

tonytanger commented Mar 20, 2023

@tengzhonger
@tonytanger
fix: if new_partitions is size 0, do not enforce size check
549e495 
Change-Id: I4e9b6507ff63df9f9ec9d57a0fc34e68e16f6e30
@tonytanger tonytanger force-pushed the remove_new_partitions_check branch from d905e4f to 549e495 Compare March 20, 2023 20:22
@tonytanger tonytanger changed the title fix: If new_partitions is size 0, do not enforce size check. Mar 20, 2023
@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 20, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 20, 2023
@mutianf mutianf added the automerge Merge the pull request once unit tests and other checks pass. label Mar 20, 2023
@gcf-merge-on-green
Copy link

gcf-merge-on-green bot commented Mar 21, 2023

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 21, 2023
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 21, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 21, 2023
@kolea2 kolea2 added the automerge Merge the pull request once unit tests and other checks pass. label Mar 21, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 07bcfd9 into googleapis:main Mar 21, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 21, 2023
@release-please release-please bot mentioned this pull request Mar 21, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 21, 2023
@release-please
chore(main): release 2.20.1 (#1672)
1cd41d6 
🤖 I have created a release *beep* *boop*
---


## [2.20.1](https://togithub.com/googleapis/java-bigtable/compare/v2.20.0...v2.20.1) (2023-03-21)


### Bug Fixes

* If new_partitions is size 0, do not enforce size check ([#1673](https://togithub.com/googleapis/java-bigtable/issues/1673)) ([07bcfd9](https://togithub.com/googleapis/java-bigtable/commit/07bcfd9a0967f781fb8e5e0d764654dbf7bcda91))


### Dependencies

* Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.14.0 ([#1668](https://togithub.com/googleapis/java-bigtable/issues/1668)) ([06f9615](https://togithub.com/googleapis/java-bigtable/commit/06f96156705a2a7897a31d11dad864afe94de693))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.5.0 ([#1670](https://togithub.com/googleapis/java-bigtable/issues/1670)) ([74cebf3](https://togithub.com/googleapis/java-bigtable/commit/74cebf3a5ab58f3fd3ae95583ba2421b733deda8))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.

4 participants

@tonytanger @mutianf @yoshi-kokoro @kolea2