fix(pubsub): move flow control release to callback completion#9311
Merged
hongalex merged 3 commits intogoogleapis:mainfrom Jan 26, 2024
Merged
fix(pubsub): move flow control release to callback completion#9311hongalex merged 3 commits intogoogleapis:mainfrom
hongalex merged 3 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
size: m
shollyman
reviewed
Jan 26, 2024
shollyman
approved these changes
Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the flow control release to the end of the user callback rather than to the message
doneFunc. This further emphasizes the importance of callingackandnackwithin the callback, since callingackin a goroutine could mean that flow control resources are released too early. This behavior is already documentedFixes #9309
Internal issue: 322090131