feat(pubsub): support message filtering in pstest#9015
feat(pubsub): support message filtering in pstest#9015hongalex merged 21 commits intogoogleapis:mainfrom
Conversation
8e6d70b to
f9fa052
Compare
|
@shollyman review por favor... |
|
@shollyman Friendly nudge, would love to leverage this. |
|
Thank you so much for the PR. Apologies as I somehow didn't see this for the longest time. For the most part the PR looks good but I need to confirm with the team on how to tackle this since we generally try to minimize the number of third party libraries. |
c5881e4 to
ffe6305
Compare
|
@hongalex Hi! Thanks for your reviews. Just added test for escapes characters and rebased to main. |
|
Checks are failing because of a minor formatting issue that running |
Thanks! Seems it requires another approval to trigger the workflow:) |
|
One more vet issue, the exported |
Added the comment. Couldn't succeed in running |
Head branch was pushed to by a user without write access
|
Checked the error message stating that (However, the test |
|
I'm so happy this is merged, thank you gcloud team ❤️ |
Resolves #8582
The implementation:
go.einride.tech/aip.