feat(bigtable): Adding support to schema bundles#12516
feat(bigtable): Adding support to schema bundles#12516bhshkh merged 10 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
the
api: bigtable
bhshkh
added
the
do not merge
ron-gal
removed
the
do not merge
| } | ||
|
|
||
| // UpdateSchemaBundle updates a schema bundle in a table according to the given configuration. | ||
| func (ac *AdminClient) UpdateSchemaBundle(ctx context.Context, conf UpdateSchemaBundleConf) error { |
There was a problem hiding this comment.
What happens when there are multiple fields that can be updated? How will UpdateSchemaBundleFromConf know which fields from SchemaBundleConf need to be included in update request? How will it differentiate between null and unset ?
There was a problem hiding this comment.
If file\slice is empty, we don't need to update it (currently it's kinda weird, as it's the only field that can change). In the future if we have more we will need to make sense of each field - what is the best way to know it should not be updated. If push comes to shove, we can allow the future user to set the update field mask, or maybe make distinct functions per field (like we have for table: UpdateTableWithChangeStream, UpdateTableWithDeletionProtection, UpdateTableDisableAutomatedBackupPolicy...)
Co-authored-by: Baha Aiman <bahaaiman@google.com>
2 participants
No description provided.