fix(bigtable): Correct the 'method' label value#11350
Merged
bhshkh merged 2 commits intogoogleapis:mainfrom Dec 27, 2024
Merged
fix(bigtable): Correct the 'method' label value#11350bhshkh merged 2 commits intogoogleapis:mainfrom
bhshkh merged 2 commits intogoogleapis:mainfrom
Conversation
bhshkh
commented
Dec 27, 2024
| } | ||
|
|
||
| if diff := testutil.Diff(gotClient.metricsTracerFactory.clientAttributes, wantClientAttributes, | ||
| cmpopts.IgnoreUnexported(attribute.KeyValue{}, attribute.Value{})); diff != "" { |
Contributor
Author
There was a problem hiding this comment.
Removed this as all the fields in attribute.Value are unexported and nothing was getting compared
https://github.com/open-telemetry/opentelemetry-go/blob/v1.29.0/attribute/value.go#L21-L27
mutianf
approved these changes
Dec 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is what Bigtable Go library is writing to monitoring server while exporting client side metrics
The method label exported by Java client is "Bigtable.ReadRows".
Updating the Go client in this PR to match Java implementation.