fix(pubsub): convert stream ack deadline seconds from duration#11214
Merged
hongalex merged 3 commits intogoogleapis:mainfrom Dec 4, 2024
Merged
fix(pubsub): convert stream ack deadline seconds from duration#11214hongalex merged 3 commits intogoogleapis:mainfrom
hongalex merged 3 commits intogoogleapis:mainfrom
Conversation
shollyman
reviewed
Dec 3, 2024
pubsub/iterator.go
Outdated
| it.eoMu.RLock() | ||
| if it.sendNewAckDeadline { | ||
| spr.StreamAckDeadlineSeconds = int32(it.ackDeadline()) | ||
| spr.StreamAckDeadlineSeconds = int32(it.ackDeadline()) / int32(time.Second) |
Contributor
There was a problem hiding this comment.
Might be more readable to use https://pkg.go.dev/time#Duration.Seconds and cast from there, rather than doing unit division.
shollyman
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10557