Skip to content

Commit 4c34ddd

Browse files
committed
http2: delete multipart form tempfiles after ServeHTTP returns
Do the same post-handler cleanup as the HTTP/1 server does. No test here; test for HTTP/1 and HTTP/2 in CL 423194. For golang/go#20253. Change-Id: Iba54110ad2844571076c721d7ec19c39ba36de79 Reviewed-on: https://go-review.googlesource.com/c/net/+/423055 Reviewed-by: Robert Griesemer <gri@google.com> Run-TryBot: Damien Neil <dneil@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
1 parent 1d4ff48 commit 4c34ddd

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

‎http2/server.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2229,6 +2229,9 @@ func (sc *serverConn) runHandler(rw *responseWriter, req *http.Request, handler
22292229
didPanic := true
22302230
defer func() {
22312231
rw.rws.stream.cancelCtx()
2232+
if req.MultipartForm != nil {
2233+
req.MultipartForm.RemoveAll()
2234+
}
22322235
if didPanic {
22332236
e := recover()
22342237
sc.writeFrameFromHandler(FrameWriteRequest{

0 commit comments

Comments
 (0)