Skip to content

modify: Add statement timeout query parmeter for MySQL #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 27, 2022
Merged

modify: Add statement timeout query parmeter for MySQL #778

merged 4 commits into from
Jul 27, 2022

Conversation

@Dombo
Copy link
Contributor

@Dombo Dombo commented Jul 25, 2022

Similarly to #327 this adds a statement timeout configuration parameter to the MySQL driver by way of an optional query parameter.
Dombo
Dombo commented Jul 25, 2022
View reviewed changes
@coveralls
Copy link

coveralls commented Jul 25, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 57.775% when pulling 9b9df6e on Dombo:mysql-statement-timeout into eebc4c4 on golang-migrate:master.
@Dombo
Copy link
Contributor Author

Dombo commented Jul 25, 2022

@dhui, @Fontinalis please take a look when you have a chance

Appreciate your efforts!
@Dombo Dombo force-pushed the mysql-statement-timeout branch from 10ca7b2 to f3b5825 Compare July 26, 2022 09:50
dhui
dhui reviewed Jul 27, 2022
View reviewed changes
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and thanks for linking #327 !
@Dombo Dombo requested a review from dhui July 27, 2022 12:26
@dhui dhui merged commit 3bba76f into golang-migrate:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@Dombo @coveralls @dhui