Skip to content

Fix truncate benchmarks, add more benchmark tests for longer strings #13880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fix truncate benchmarks, add more benchmark tests for longer strings #13880

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4bd2cc6
add Truncate benchmarks for longer texts
Nigel2392 Jul 28, 2025
2eb3843
add even longer texts for Truncate benchmarks
Nigel2392 Jul 28, 2025
a462400
Update truncate_test.go
Nigel2392 Jul 28, 2025
664aad4
Merge branch 'master' into expand-truncate-benchmarks-clean
Nigel2392 Aug 21, 2025
e0dd52f
Merge https://github.com/Nigel2392/hugo into expand-truncate-benchmar…
Nigel2392 Sep 19, 2025
18c2bcb
fix formatting
Nigel2392 Sep 19, 2025
6211315
fix formatting
Nigel2392 Sep 19, 2025
841543b
Delete .vscode/settings.json
Nigel2392 Sep 19, 2025
872fcba
fix formatting
Nigel2392 Sep 19, 2025
828d925
Merge branch 'expand-truncate-benchmarks-clean' of https://github.com…
Nigel2392 Sep 19, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix formatting
  • Loading branch information
@Nigel2392
Nigel2392 committed Sep 19, 2025
commit 18c2bcb74676f25640b57a165392ee007678e339
3 changes: 3 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"workbench.colorTheme": "Seti Monokai: Original"
}
10 changes: 5 additions & 5 deletions tpl/strings/truncate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ func BenchmarkTruncate(b *testing.B) {

b.Run("With link", func(b *testing.B) {
for i := 0; i < b.N; i++ {
ns.Truncate(10, "I have a <a href='/markdown'>Markdown link</a> inside")
ns.Truncate(10, template.HTML("I have a <a href='/markdown'>Markdown link</a> inside"))
}
})

Expand All @@ -123,10 +123,10 @@ Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deseru

b.Run("With HTML (medium)", func(b *testing.B) {
for i := 0; i < b.N; i++ {
ns.Truncate(371, `Lorem ipsum dolor sit amet, <span>consectetur adipiscing elit</span>, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
ns.Truncate(371, template.HTML(`Lorem ipsum dolor sit amet, <span>consectetur adipiscing elit</span>, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
Ut enim ad minim veniam, <p>quis nostrud exercitation ullamco</p> laboris nisi ut aliquip ex ea commodo consequat.
Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.
Excepteur <code>sint occaecat cupidatat</code> non proident, <a href="#my-text">sunt in culpa qui officia deserunt mollit anim id est</a> laborum.`)
Excepteur <code>sint occaecat cupidatat</code> non proident, <a href="#my-text">sunt in culpa qui officia deserunt mollit anim id est</a> laborum.`))
}
})

Expand All @@ -152,7 +152,7 @@ Itaque earum rerum hic tenetur a sapiente delectus, ut aut reiciendis voluptatib

b.Run("HTML text (long)", func(b *testing.B) {
for i := 0; i < b.N; i++ {
ns.Truncate(1850, `Lorem ipsum dolor sit amet, <span>consectetur adipiscing elit</span>, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
ns.Truncate(1850, template.HTML(`Lorem ipsum dolor sit amet, <span>consectetur adipiscing elit</span>, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
Ut enim ad minim veniam, <p>quis nostrud exercitation ullamco</p> laboris nisi ut aliquip ex ea commodo consequat.
Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.
Excepteur <code>sint occaecat cupidatat</code> non proident, <a href="#my-text">sunt in culpa qui officia deserunt mollit anim id est</a> laborum.
Expand All @@ -166,7 +166,7 @@ occaecati cupiditate non provident, <div class="my-text-class">similique sunt in
Et harum quidem rerum facilis est et expedita distinctio. Nam libero tempore, cum soluta nobis est eligendi optio cumque nihil impedit quo minus id quod maxime placeat
facere possimus, omnis voluptas assumenda est, omnis dolor repellendus.
Temporibus autem quibusdam et aut officiis debitis aut rerum necessitatibus saepe <h3>eveniet ut et voluptates repudiandae sint et molestiae non recusandae.</h3>
Itaque earum rerum hic tenetur a sapiente delectus, ut aut reiciendis voluptatibus maiores alias consequatur aut perferendis doloribus asperiores repellat.`)
Itaque earum rerum hic tenetur a sapiente delectus, ut aut reiciendis voluptatibus maiores alias consequatur aut perferendis doloribus asperiores repellat.`))
}
})

Expand Down