Skip to content

Iss9148 add debug list #13031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Iss9148 add debug list #13031

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36df350
debug: Add method debug.List
johannesengl Mar 8, 2023
c91de88
refactor: user struct to for and bar in debug tests to improve tests …
zepyrshut Nov 12, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor: user struct to for and bar in debug tests to improve tests … 
…abstraction

#9148 and rebased #10806
  • Loading branch information
@zepyrshut
zepyrshut committed Nov 12, 2024
commit c91de885b578639e30e66040cf919d4c73d44f85
2 changes: 0 additions & 2 deletions tpl/debug/debug.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@ import (
"reflect"
"sort"

"github.com/sanity-io/litter"
"encoding/json"
"sort"
"sync"
"time"

Expand Down
21 changes: 10 additions & 11 deletions tpl/debug/debug_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,18 @@ import (
"testing"
)

type User struct {
Name string
Address any
foo string
type Foo struct {
Bar string
foo any
}

func (u *User) M1() string { return "" }
func (u *User) M2(v string) string { return "" }
func (u *User) m3(v string) string { return "" }
func (f *Foo) M1() string { return "" }
func (f *Foo) M2(v string) string { return "" }
func (f *Foo) m3(v string) string { return "" }

// Non Pointer type methods
func (u User) M4(v string) string { return "" }
func (u User) m5(v string) string { return "" }
func (f Foo) M4(v string) string { return "" }
func (f Foo) m5(v string) string { return "" }

func TestList(t *testing.T) {
t.Parallel()
Expand All @@ -46,9 +45,9 @@ func TestList(t *testing.T) {
// Map non string keys
{map[int]any{1: 1, 2: 2, 3: 3}, []string{"<int Value>", "<int Value>", "<int Value>"}},
// Struct
{User{}, []string{"Name", "Address", "M1", "M2", "M4"}},
{Foo{}, []string{"Bar", "M1", "M2", "M4"}},
// Pointer
{&User{}, []string{"Name", "Address", "M1", "M2", "M4"}},
{&Foo{}, []string{"Bar", "M1", "M2", "M4"}},
} {
t.Run(fmt.Sprintf("test%d", i), func(t *testing.T) {
result := namespace.List(test.val)
Expand Down