Update golangci-lint to v2.6.0 #35801
Open
+108
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
topic/code-linting
modifies/api
|
I think I will revert these string builder changes and disable the offending rule, it seems useless. |
|
The It says "This avoids quadratic memory allocation and improves performance." so maybe it is worth it. I will fix those var names. |
|
I manually cleaned up the stringsbuilder cases, should be ready. |
lunny
reviewed
Nov 2, 2025
| } | ||
| text += fmt.Sprintf("[%s](%s) %s", commit.ID[:7], commit.URL, | ||
| strings.TrimRight(commit.Message, "\r\n")) + authorName | ||
| textSb.WriteString(fmt.Sprintf("[%s](%s) %s", commit.ID[:7], commit.URL, |
lunny
reviewed
Nov 2, 2025
| message = fmt.Sprintf("%.47s...", message) | ||
| } | ||
| text += fmt.Sprintf("[%s](%s) %s - %s", commit.ID[:7], commit.URL, message, commit.Author.Name) | ||
| textSb.WriteString(fmt.Sprintf("[%s](%s) %s - %s", commit.ID[:7], commit.URL, message, commit.Author.Name)) |
lunny
reviewed
Nov 2, 2025
|
|
||
| text := fmt.Sprintf("[%s:%s] %s\r\n", p.Repo.FullName, branchName, commitDesc) | ||
| var textSb strings.Builder | ||
| textSb.WriteString(fmt.Sprintf("[%s:%s] %s\r\n", p.Repo.FullName, branchName, commitDesc)) |
lunny
reviewed
Nov 2, 2025
| } | ||
| text += fmt.Sprintf("[%s](%s) %s", commit.ID[:7], commit.URL, | ||
| strings.TrimRight(commit.Message, "\r\n")) + authorName | ||
| textSb.WriteString(fmt.Sprintf("[%s](%s) %s", commit.ID[:7], commit.URL, |
lunny
reviewed
Nov 2, 2025
| text := fmt.Sprintf("[%s] %s pushed %s to %s:<br>", repoLink, p.Pusher.UserName, commitDesc, branchLink) | ||
|
|
||
| var textSb strings.Builder | ||
| textSb.WriteString(fmt.Sprintf("[%s] %s pushed %s to %s:<br>", repoLink, p.Pusher.UserName, commitDesc, branchLink)) |
lunny
reviewed
Nov 2, 2025
| // for each commit, generate a new line text | ||
| for i, commit := range p.Commits { | ||
| text += fmt.Sprintf("%s: %s - %s", htmlLinkFormatter(commit.URL, commit.ID[:7]), commit.Message, commit.Author.Name) | ||
| textSb.WriteString(fmt.Sprintf("%s: %s - %s", htmlLinkFormatter(commit.URL, commit.ID[:7]), commit.Message, commit.Author.Name)) |
lunny
reviewed
Nov 2, 2025
| for i, commit := range p.Commits { | ||
| text += fmt.Sprintf("[%s](%s) %s - %s", commit.ID[:7], commit.URL, | ||
| strings.TrimRight(commit.Message, "\r\n"), commit.Author.Name) | ||
| textSb.WriteString(fmt.Sprintf("[%s](%s) %s - %s", commit.ID[:7], commit.URL, |
lunny
reviewed
Nov 2, 2025
| var attachmentTextSb strings.Builder | ||
| for i, commit := range p.Commits { | ||
| attachmentText += fmt.Sprintf("%s: %s - %s", SlackLinkFormatter(commit.URL, commit.ID[:7]), SlackShortTextFormatter(commit.Message), SlackTextFormatter(commit.Author.Name)) | ||
| attachmentTextSb.WriteString(fmt.Sprintf("%s: %s - %s", SlackLinkFormatter(commit.URL, commit.ID[:7]), SlackShortTextFormatter(commit.Message), SlackTextFormatter(commit.Author.Name))) |
lunny
reviewed
Nov 2, 2025
| var htmlCommitsSb strings.Builder | ||
| for _, commit := range p.Commits { | ||
| htmlCommits += fmt.Sprintf("\n[%s] %s", htmlLinkFormatter(commit.URL, commit.ID[:7]), html.EscapeString(strings.TrimRight(commit.Message, "\r\n"))) | ||
| htmlCommitsSb.WriteString(fmt.Sprintf("\n[%s] %s", htmlLinkFormatter(commit.URL, commit.ID[:7]), html.EscapeString(strings.TrimRight(commit.Message, "\r\n")))) |
lunny
reviewed
Nov 2, 2025
| message := strings.ReplaceAll(commit.Message, "\n\n", "\r\n") | ||
| text += fmt.Sprintf(" > [%s](%s) \r\n ><font color=\"info\">%s</font> \n ><font color=\"warning\">%s</font>", commit.ID[:7], commit.URL, | ||
| message, authorName) | ||
| textSb.WriteString(fmt.Sprintf(" > [%s](%s) \r\n ><font color=\"info\">%s</font> \n ><font color=\"warning\">%s</font>", commit.ID[:7], commit.URL, |
lunny
reviewed
Nov 2, 2025
| func (p *Permission) LogString() string { | ||
| format := "<Permission AccessMode=%s, %d Units, %d UnitsMode(s): [" | ||
| var formatSb strings.Builder | ||
| formatSb.WriteString("<Permission AccessMode=%s, %d Units, %d UnitsMode(s): [") |
There was a problem hiding this comment.
Just use fmt.Fprintf so that no args is needed.
|
I really dislike unnecessary lint rules. And I have strong objection for this Sprintf change, it doesn't improve readability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/golangci/golangci-lint/releases/tag/v2.6.0
modernizelinter is enabled, this is the same asgopls modernizeperfsprintlinter is disabled because it conflicts withmodernize(maybe there is a middle ground)deprecatedCommentis disabled as it conflicts withgo-swagger