-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Fix circular spin animation direction #35785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@silverwind what do you think about the new change? It looks good to me. |
I have a better idea. 'octicon sync' is a counterclockwise icon used to represent the state of rollback or rerun. If it is a rollback or rerun, we should use a counterclockwise icon and a counterclockwise rotation animation. If it is ongoing, first-time, or one-time execution, we should use a clockwise icon and a clockwise rotation animation. This can be a bit troublesome because I am not very clear about the specific purpose of some pages. |
|
Maybe no need to make it that complex. When it is a static icon, I guess few people would really look carefully at it to see whether it is clockwise or counterclockwise |
|
I agree, but I can't see the specific page. It seems like there's no problem looking at the code? If possible, I will modify and submit it like this. |
|
Should be safe to replace "blindly" if the icon size is the same. |
Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
|
The viewBox for |
Wait for the status icon to rotate clockwise instead of counterclockwise before:  after:  --------- Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com> Signed-off-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: lutinglt <lutinglt@users.noreply.github.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>







Wait for the status icon to rotate clockwise instead of counterclockwise
before:

after:

This can be merged to 1.25