Skip to content

Remove ctx in the git repository struct #35601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Remove ctx in the git repository struct #35601

wants to merge 2 commits into from
+1,493 −1,436

Conversation

@lunny
Copy link
Member

@lunny lunny commented Oct 7, 2025

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Oct 7, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 7, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/migrations labels Oct 7, 2025
wxiaoguang
wxiaoguang requested changes Nov 2, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely wrong for CatFileBatch, the ctx is abused.
@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 2, 2025
@lunny lunny closed this Nov 2, 2025
@lunny
Copy link
Member Author

lunny commented Nov 2, 2025

It's just an experiment PR. You are right it's not easy.
@lunny lunny deleted the lunny/remove_git_repository_ctx branch November 2, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged modifies/api This PR adds API routes or modifies them modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code modifies/migrations type/refactoring Existing code has been cleaned up. There should be no new functionality.

3 participants

@lunny @wxiaoguang @GiteaBot