allow connecting from IPv6 link-local addresses #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include the scope-id when binding an IPv6 socket, as required for IPv6 link-local addresses. Not doing this would make the OS reject the bind and throw an exception, disconnecting the client.
|
This looks convoluted. I am not sure when I will have the resources to look at this. I feel like this belongs to ioloop.py file, and a is_local_ipv6() helper function would make things clearer, but I can't say more than this for now. IPv6 is hard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should fix #664, where clients would get rejected if they connected from a link-local IPv6-address (
fe80:throughfebf:). I'm not sure if this is the optimal way to fix this, but I believe it is at least sound :-)I didn't add a test for this, since I think it would require an IPv6 link-local address to connect from, and I'm not sure how to assign one without running the test as root.
The tests did not seem any worse for the wear on either Windows, Linux, or Macos -- on Linux I did have to replace
net_connectionswithconnectionsinpyftpdlib/test/*.pyand on Macos there was a small number of seemingly unrelated issues; pyftpdlib-test-macos.txt