Feature/fix throttled dtp handler #320
Open
+2,523
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call socket.setsockopt() to do this befor active or passive data connection is establisched. Fix throttleing data rate handling to use the configured bandwith exactily.
|
I won't have time to look into this any time soon. Please have some patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had problems with a new MS feature.
see http://en.wikipedia.org/wiki/TCP_tuning and
https://technet.microsoft.com/en-us/magazine/2007.01.cableguy.aspx
We have a proprietary TCP tunnel with a really long RTT > 3 sec and a MSS of 21 kBytes to an embedded ftp client.
With throttling I tried to not send more than 21 kBytes per 3 seconds -> i.e. 7 kBytes/sec but this was not enough.
Note, this new microsoft feature can't not really disabled for one interface only!
To prevent a lot of TCP retransmissions and delayed ACK's I should be able to set the socket receive buffer and transmit buffer size.
I have prepared a patch to enable this feature using socket.setsockopt().