Skip to content

Commit a4988a5

Browse files
authored
Merge pull request #28 from gemini-testing/sp.timestampForRetries
Add timestamp for retries
2 parents 4c60e7c + 25d88d7 commit a4988a5

File tree

2 files changed

+22
-8
lines changed

2 files changed

+22
-8
lines changed

‎lib/collector/index.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,12 @@ module.exports = class Collector {
2222
}
2323

2424
addFail(result) {
25-
const {message, stack} = result.err;
25+
const {startTime, duration, err: {message, stack}} = result;
2626

2727
this._addTestResult(result, {
2828
status: 'fail',
2929
errorReason: {message, stack},
30-
retries: [{message, stack}]
30+
retries: [{message, stack, startTime, duration}]
3131
});
3232
}
3333

@@ -43,12 +43,12 @@ module.exports = class Collector {
4343
}
4444

4545
addError(result) {
46-
const {message, stack} = result;
46+
const {message, stack, startTime, duration} = result;
4747

4848
this._addTestResult(result, {
4949
status: 'error',
5050
errorReason: {message, stack},
51-
retries: [{message, stack}]
51+
retries: [{message, stack, startTime, duration}]
5252
});
5353
}
5454

‎test/lib/collector/index.js

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ describe('collector/index', () => {
7373

7474
it('should add failed test', () => {
7575
const testError = new Promise.OperationalError('test');
76-
const data = {fullName: 'some name', browserId: 'bro', err: testError};
76+
const data = {fullName: 'some name', browserId: 'bro', err: testError, startTime: 1000, duration: 500};
7777
const collector = mkCollector_();
7878

7979
collector.addFail(data);
@@ -83,8 +83,15 @@ describe('collector/index', () => {
8383
fullName: 'some name',
8484
browserId: 'bro',
8585
status: 'fail',
86+
startTime: data.startTime,
87+
duration: data.duration,
8688
errorReason: {message: testError.message, stack: testError.stack},
87-
retries: [{message: testError.message, stack: testError.stack}]
89+
retries: [{
90+
message: testError.message,
91+
stack: testError.stack,
92+
startTime: data.startTime,
93+
duration: data.duration
94+
}]
8895
}});
8996
});
9097
});
@@ -109,7 +116,7 @@ describe('collector/index', () => {
109116

110117
it('should add failed test if the retry fails', () => {
111118
const testError = new Promise.OperationalError('test');
112-
const data = {fullName: 'some name', browserId: 'bro', err: testError};
119+
const data = {fullName: 'some name', browserId: 'bro', err: testError, startTime: 1000, duration: 500};
113120
const collector = mkCollector_();
114121

115122
collector.addRetry(data);
@@ -120,7 +127,14 @@ describe('collector/index', () => {
120127
browserId: 'bro',
121128
status: 'fail',
122129
errorReason: {message: testError.message, stack: testError.stack},
123-
retries: [{message: testError.message, stack: testError.stack}]
130+
startTime: data.startTime,
131+
duration: data.duration,
132+
retries: [{
133+
message: testError.message,
134+
stack: testError.stack,
135+
startTime: data.startTime,
136+
duration: data.duration
137+
}]
124138
}});
125139
});
126140
});

0 commit comments

Comments
 (0)