Skip to content

Commit a01ef92

Browse files
committed
fix: address code review feedback (imports, typo, perf)
Signed-off-by: devmanishofficial <devmanishofficial@gmail.com>
1 parent 22e8c8b commit a01ef92

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

‎go/MIDDLEWARE.md‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,9 @@ package main
1313

1414
import (
1515
"context"
16-
"fmt"
1716
"log"
1817

1918
"github.com/firebase/genkit/go/core"
20-
"github.com/firebase/genkit/go/genkit"
2119
)
2220

2321
func MyMiddleware[In, Out, Stream any](next core.StreamingFunc[In, Out, Stream]) core.StreamingFunc[In, Out, Stream] {

‎go/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@
33
This package is the Go version of Genkit, a framework for building
44
AI-powered apps. See: https://genkit.dev/go/docs/get-started-go
55

6-
- [Middleware Guide](MIDDLEWARE.md): Learn how to add logging, authentication, and custom logic to your flows.c
6+
- [Middleware Guide](MIDDLEWARE.md): Learn how to add logging, authentication, and custom logic to your flows.

‎go/core/tracing/tracing.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ type filteringExporter struct {
410410
}
411411

412412
func (e *filteringExporter) ExportSpans(ctx context.Context, spans []sdktrace.ReadOnlySpan) error {
413-
var genkitSpans []sdktrace.ReadOnlySpan
413+
genkitSpans := make([]sdktrace.ReadOnlySpan, 0, len(spans))
414414
for _, span := range spans {
415415
if isGenkitSpan(span) {
416416
genkitSpans = append(genkitSpans, span)

0 commit comments

Comments
 (0)