Skip to content

Commit e182238

Browse files
committed
review comments
1 parent 6f62297 commit e182238

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

‎.changeset/lazy-donuts-agree.md‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,5 @@
55

66
Added a `sendFunctionResponses` method to `LiveSession`, allowing function responses to be sent during realtime sessions.
77
Fixed an issue where function responses during audio conversations caused the WebSocket connection to close. See [GitHub Issue #9264](https://github.com/firebase/firebase-js-sdk/issues/9264).
8-
- **Breaking Change**: Changed `StartAudioConversationOptions` and `functionCallingHandler` must now return a `Promise<FunctionResponse>`.
9-
This breaking change is allowed in a minor release since the Live API is in Public Preview.
10-
- **Breaking Change**: Changed the `functionCallingHandler` property in `StartAudioConversationOptions` so that it now returns a `Promise<FunctionResponse>`.
8+
- **Breaking Change**: Changed the `functionCallingHandler` property in `StartAudioConversationOptions` so that it now must return a `Promise<FunctionResponse>`.
119
This breaking change is allowed in a minor release since the Live API is in Public Preview.

‎docs-devsite/ai.livesession.md‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,12 +152,16 @@ sendFunctionResponses(functionResponses: FunctionResponse[]): Promise<void>;
152152

153153
| Parameter | Type | Description |
154154
| --- | --- | --- |
155-
| functionResponses | [FunctionResponse](./ai.functionresponse.md#functionresponse_interface)<!-- -->\[\] | The function responses to send. If this session has been closed. |
155+
| functionResponses | [FunctionResponse](./ai.functionresponse.md#functionresponse_interface)<!-- -->\[\] | The function responses to send. |
156156

157157
<b>Returns:</b>
158158

159159
Promise&lt;void&gt;
160160

161+
#### Exceptions
162+
163+
If this session has been closed.
164+
161165
## LiveSession.sendMediaChunks()
162166

163167
> This API is provided as a preview for developers and may change based on feedback that we receive. Do not use this API in a production environment.

‎packages/ai/src/methods/live-session.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ export class LiveSession {
125125
* Sends function responses to the server.
126126
*
127127
* @param functionResponses - The function responses to send.
128-
* @throw If this session has been closed.
128+
* @throws If this session has been closed.
129129
*
130130
* @beta
131131
*/

0 commit comments

Comments
 (0)