Skip to content

Commit c4242ee

Browse files
committed
Prevent looping through AFRAME.scenes if not created yet
1 parent 2ccc8e6 commit c4242ee

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

‎dist/aframe-input-mapping-component.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,6 @@
193193
}
194194

195195
// Merge mappings
196-
var mappings = data.mappings;
197196
for (var mappingName in data.mappings) {
198197
var mapping = data.mappings[mappingName];
199198
if (!AFRAME.inputMappings.mappings[mappingName]) {
@@ -215,6 +214,8 @@
215214
}
216215
}
217216

217+
if (!AFRAME.scenes) { return; }
218+
218219
for (var i = 0; i < AFRAME.scenes.length; i++) {
219220
AFRAME.scenes[i].emit('inputmappingregistered');
220221
}

‎dist/aframe-input-mapping-component.min.js‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎index.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,6 @@ AFRAME.registerInputMappings = function (data, override) {
147147
}
148148

149149
// Merge mappings
150-
var mappings = data.mappings;
151150
for (var mappingName in data.mappings) {
152151
var mapping = data.mappings[mappingName];
153152
if (!AFRAME.inputMappings.mappings[mappingName]) {
@@ -169,6 +168,8 @@ AFRAME.registerInputMappings = function (data, override) {
169168
}
170169
}
171170

171+
if (!AFRAME.scenes) { return; }
172+
172173
for (var i = 0; i < AFRAME.scenes.length; i++) {
173174
AFRAME.scenes[i].emit('inputmappingregistered');
174175
}

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "aframe-input-mapping-component",
3-
"version": "0.1.0",
3+
"version": "0.1.1",
44
"description": "A Input Mapping component for A-Frame.",
55
"main": "index.js",
66
"unpkg": "dist/aframe-input-mapping-component.min.js",

0 commit comments

Comments
 (0)