Use most recent React version #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
|
Hmm. Can we change the script to run |
Contributor
|
@gaearon that would be way better than trying to move dev dependencies around and re-run npm blindly on the host folder! |
Contributor
Author
|
Should I also run |
Contributor
|
Yes please. (We might remove it until some issues are solved but I'll make the call before cutting the release.) |
Contributor
Author
|
@gaearon Updated it to run separate installs for each package. |
scripts/init.js
Outdated
| pkg === 'react-test-renderer' ? '--save-dev' : '--save', | ||
| verbose && '--verbose' | ||
| ].filter(function(e) { return e; }); | ||
| var result = spawnSync('npm', args, {stdio: 'inherit'}); |
Contributor
There was a problem hiding this comment.
These should not be three separate spawns.
Let's just use --save for all of them, and do it as one spawn.
Contributor
|
Thanks! |
gaearon
pushed a commit
that referenced
this pull request
Aug 25, 2016
* Get latest version numbers of react and react-dom from npm before install. * Run separate npm installs for react, react-dom, and react-test-renderer. * Consolidate into a single npm install. * Fix misplaced parenthesis, add missing semicolon. * Add missing semicolon.
Merged
stayradiated
pushed a commit
to stayradiated/create-react-app
that referenced
this pull request
Sep 7, 2016
* Get latest version numbers of react and react-dom from npm before install. * Run separate npm installs for react, react-dom, and react-test-renderer. * Consolidate into a single npm install. * Fix misplaced parenthesis, add missing semicolon. * Add missing semicolon.
feiqitian
pushed a commit
to feiqitian/create-react-app
that referenced
this pull request
Oct 25, 2016
* Get latest version numbers of react and react-dom from npm before install. * Run separate npm installs for react, react-dom, and react-test-renderer. * Consolidate into a single npm install. * Fix misplaced parenthesis, add missing semicolon. * Add missing semicolon.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #473. I thought the best approach would be calling
npm view react[-dom] versionand then using the output. If it fails, it falls back to the old method of getting the version. The other alternative I considered was just doing a separate install of react and react-dom, but then you'd end up with more extra npm installs.Test plan: I ran
initand the new app had version^15.3.1in the package.json, instead of^15.3.0, which is how it is in thecreate-react-apprepo and when creating a new app off of master.