Skip to content

[e2e] clean up changes to npm and yarn registry #3756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2018
Merged

[e2e] clean up changes to npm and yarn registry #3756

merged 1 commit into from
Jan 11, 2018

Conversation

@viankakrisna
Copy link
Contributor

@viankakrisna viankakrisna commented Jan 11, 2018

tried running yarn e2e locally and it messes up my registry config 😅 need to do something about npm install npm@latest though, maybe use nvm?
@gaearon gaearon merged commit b02fe66 into facebook:master Jan 11, 2018
@gaearon
Copy link
Contributor

gaearon commented Jan 11, 2018

Looks good, thanks!
@viankakrisna viankakrisna deleted the cleanup-e2e branch January 12, 2018 08:15
@gaearon gaearon mentioned this pull request Jan 15, 2018
Merged
@ghost ghost mentioned this pull request Jan 15, 2018
Merged
This was referenced Feb 2, 2018
Closed
Closed
Closed
Closed
Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018
@viankakrisna
clean up changes to npm and yarn registry (facebook#3756)
87492d3
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed tag: internal

4 participants

@viankakrisna @gaearon @Timer @facebook-github-bot