Skip to content

tests: migrate KV semantics (e2e/ctl_v3_kv) to common test framework #20730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+58 −1
Open

tests: migrate KV semantics (e2e/ctl_v3_kv) to common test framework #20730

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0de3a2
Migrate ctl_v3_kv_test.go from e2e to common framework
Sep 26, 2025
89d6a0f
Migrate TestCtlV3PutTimeout from e2e to integration framework
Sep 28, 2025
8fb1682
Remove the TestCtlV3PutTimeout from e2e
lavishpal Sep 29, 2025
309efa5
Remove the TestCtlV3PutTimeout from e2e
lavishpal Sep 29, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove the TestCtlV3PutTimeout from e2e 
Signed-off-by: Lavish Pal <lvishpal408@gmail.com>
  • Loading branch information
@lavishpal
lavishpal committed Sep 29, 2025
commit 309efa5ed1aa328e0edb6e885721cbeddc46c611
2 changes: 0 additions & 2 deletions tests/common/v3_kv_test.go
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of creating a new file, we can add tests in tests/common/kv_test.go.
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ import (
"go.etcd.io/etcd/tests/v3/framework/testutils"
)

// TestKV_PutTimeout migrates TestCtlV3PutTimeout from e2e to integration framework
// Original e2e test: func TestCtlV3PutTimeout(t *testing.T) { testCtl(t, putTest, withDefaultDialTimeout()) }
func TestKV_PutTimeout(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the matching e2e that its being migrated
testRunner.BeforeTest(t)
for _, tc := range clusterTestCases() {
Expand Down