Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: OttoWinter/AsyncTCP
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: esphome/AsyncTCP
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 19 commits
  • 14 files changed
  • 7 contributors

Commits on May 5, 2021

  1. Better fix for "ack timeout 4" client disconnects.

    After my first attempt at fixing the client disconnects
    (#4) got merged
    into AsyncTCP, it turned out that there was regression
    for some devices: the connection stability actually went
    down instead of up.
    
    After a lot of debugging and discussion with @glmnet (some of
    the results can be found in the above pull request discussion),
    we came up with an improved fix for the disconnect issues.
    
    **Changed:**
    
    The code that checks for ACK timeouts has been simplified in
    such way, that only two timestamps are now used to determine if
    an ACK timeout has happened: the time of the last sent packet
    (this was already recorded), and the time of the last received
    ACK from the client (this has been added).
    
    Using these timestamps, there is no more need for a separate field
    to keep track if we are waiting for an ACK or not (`_pcb_busy`).
    Therefore, this field was completely removed from the code.
    
    While I was at it, I renamed a few variables to make the code
    easier to read and more consistent.
    
    **Results:**
    
    I connected Home Assistant plus 8 OTA loggers at the same time,
    using very verbose logging output. This normally was an easy way
    to trigger the disconnect errors.
    
    It turned out, this solution runs as solid for me, as when disabling
    the ACK timeout checks completely
    (using `AsyncClient::setAckTimeout(0)`).
    Maurice Makaay committed May 5, 2021
    Configuration menu
    Copy the full SHA
    6f37967 View commit details
    Browse the repository at this point in the history
  2. Define one_day var as a const.

    Maurice Makaay committed May 5, 2021
    Configuration menu
    Copy the full SHA
    18ac673 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2021

  1. Merge pull request #1 from mmakaay/master

    Better fix for "ack timeout 4" client disconnects.
    glmnet authored May 9, 2021
    Configuration menu
    Copy the full SHA
    bfcba1f View commit details
    Browse the repository at this point in the history
  2. Bump version to 1.2.2

    glmnet committed May 9, 2021
    Configuration menu
    Copy the full SHA
    7c767c3 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. Configuration menu
    Copy the full SHA
    fb0411b View commit details
    Browse the repository at this point in the history
  2. Bump version to 2.0.0

    jesserockz authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    c043464 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Configuration menu
    Copy the full SHA
    c533684 View commit details
    Browse the repository at this point in the history
  2. Bump version to 2.0.1

    jesserockz authored Sep 1, 2023
    Configuration menu
    Copy the full SHA
    dc64fed View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. IPv6 support added (#5)

    Co-authored-by: Paweł pidpawel Kozubal <pawel.kozubal@husarnet.com>
    HeMan and pidpawel authored Dec 21, 2023
    2 Configuration menu
    Copy the full SHA
    42a8644 View commit details
    Browse the repository at this point in the history
  2. Bump version to 2.1.0

    jesserockz committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    ab9b7d4 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Configuration menu
    Copy the full SHA
    bf3e4d2 View commit details
    Browse the repository at this point in the history
  2. Bump version to 2.1.1

    jesserockz committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    117fee9 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Configuration menu
    Copy the full SHA
    87d4daa View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Bump version to 2.1.2

    jesserockz committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    d852ef9 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2024

  1. Fixes libretiny (me-no-dev#10)

    HeMan authored Feb 18, 2024
    Configuration menu
    Copy the full SHA
    2ae3787 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Bump version to 2.1.3

    jesserockz committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    54fcd10 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Configuration menu
    Copy the full SHA
    cd05918 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. Configuration menu
    Copy the full SHA
    609b4ba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    acdd7cd View commit details
    Browse the repository at this point in the history
Loading