forked from me-no-dev/AsyncTCP
-
Notifications
You must be signed in to change notification settings - Fork 5
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: OttoWinter/AsyncTCP
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: esphome/AsyncTCP
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 19 commits
- 14 files changed
- 7 contributors
Commits on May 5, 2021
-
Better fix for "ack timeout 4" client disconnects.
After my first attempt at fixing the client disconnects (#4) got merged into AsyncTCP, it turned out that there was regression for some devices: the connection stability actually went down instead of up. After a lot of debugging and discussion with @glmnet (some of the results can be found in the above pull request discussion), we came up with an improved fix for the disconnect issues. **Changed:** The code that checks for ACK timeouts has been simplified in such way, that only two timestamps are now used to determine if an ACK timeout has happened: the time of the last sent packet (this was already recorded), and the time of the last received ACK from the client (this has been added). Using these timestamps, there is no more need for a separate field to keep track if we are waiting for an ACK or not (`_pcb_busy`). Therefore, this field was completely removed from the code. While I was at it, I renamed a few variables to make the code easier to read and more consistent. **Results:** I connected Home Assistant plus 8 OTA loggers at the same time, using very verbose logging output. This normally was an easy way to trigger the disconnect errors. It turned out, this solution runs as solid for me, as when disabling the ACK timeout checks completely (using `AsyncClient::setAckTimeout(0)`).
Maurice Makaay committedMay 5, 2021 Configuration menu - View commit details
-
Copy full SHA for 6f37967 - Browse repository at this point
Copy the full SHA 6f37967View commit details -
Define one_day var as a const.
Maurice Makaay committedMay 5, 2021 Configuration menu - View commit details
-
Copy full SHA for 18ac673 - Browse repository at this point
Copy the full SHA 18ac673View commit details
Commits on May 9, 2021
-
Merge pull request #1 from mmakaay/master
Better fix for "ack timeout 4" client disconnects.
Configuration menu - View commit details
-
Copy full SHA for bfcba1f - Browse repository at this point
Copy the full SHA bfcba1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c767c3 - Browse repository at this point
Copy the full SHA 7c767c3View commit details
Commits on Aug 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fb0411b - Browse repository at this point
Copy the full SHA fb0411bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c043464 - Browse repository at this point
Copy the full SHA c043464View commit details
Commits on Sep 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c533684 - Browse repository at this point
Copy the full SHA c533684View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc64fed - Browse repository at this point
Copy the full SHA dc64fedView commit details
Commits on Dec 21, 2023
-
Co-authored-by: Paweł pidpawel Kozubal <pawel.kozubal@husarnet.com>
2Configuration menu - View commit details
-
Copy full SHA for 42a8644 - Browse repository at this point
Copy the full SHA 42a8644View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab9b7d4 - Browse repository at this point
Copy the full SHA ab9b7d4View commit details
Commits on Jan 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bf3e4d2 - Browse repository at this point
Copy the full SHA bf3e4d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 117fee9 - Browse repository at this point
Copy the full SHA 117fee9View commit details
Commits on Jan 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 87d4daa - Browse repository at this point
Copy the full SHA 87d4daaView commit details
Commits on Feb 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d852ef9 - Browse repository at this point
Copy the full SHA d852ef9View commit details
Commits on Feb 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2ae3787 - Browse repository at this point
Copy the full SHA 2ae3787View commit details
Commits on Feb 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 54fcd10 - Browse repository at this point
Copy the full SHA 54fcd10View commit details
Commits on Sep 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cd05918 - Browse repository at this point
Copy the full SHA cd05918View commit details
Commits on Sep 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 609b4ba - Browse repository at this point
Copy the full SHA 609b4baView commit details -
Configuration menu - View commit details
-
Copy full SHA for acdd7cd - Browse repository at this point
Copy the full SHA acdd7cdView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...main