Skip to content

Commit 35183af

Browse files
committed
Consolidate rendering of where model
1 parent 5e87f08 commit 35183af

File tree

4 files changed

+9
-22
lines changed

4 files changed

+9
-22
lines changed

‎src/main/java/org/mybatis/dynamic/sql/delete/render/DeleteRenderer.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
import org.mybatis.dynamic.sql.util.FragmentAndParameters;
3232
import org.mybatis.dynamic.sql.util.FragmentCollector;
3333
import org.mybatis.dynamic.sql.where.WhereModel;
34-
import org.mybatis.dynamic.sql.where.render.WhereRenderer;
3534

3635
public class DeleteRenderer {
3736
private final DeleteModel deleteModel;
@@ -78,10 +77,7 @@ private Optional<FragmentAndParameters> calculateWhereClause() {
7877
}
7978

8079
private Optional<FragmentAndParameters> renderWhereClause(WhereModel whereModel) {
81-
return WhereRenderer.withWhereModel(whereModel)
82-
.withRenderingContext(renderingContext)
83-
.build()
84-
.render();
80+
return whereModel.render(renderingContext);
8581
}
8682

8783
private Optional<FragmentAndParameters> calculateLimitClause() {

‎src/main/java/org/mybatis/dynamic/sql/select/render/QueryExpressionRenderer.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
import org.mybatis.dynamic.sql.util.FragmentCollector;
3434
import org.mybatis.dynamic.sql.util.StringUtilities;
3535
import org.mybatis.dynamic.sql.where.WhereModel;
36-
import org.mybatis.dynamic.sql.where.render.WhereRenderer;
3736

3837
public class QueryExpressionRenderer {
3938
private final QueryExpressionModel queryExpression;
@@ -168,10 +167,7 @@ private Optional<FragmentAndParameters> calculateWhereClause() {
168167
}
169168

170169
private Optional<FragmentAndParameters> renderWhereClause(WhereModel whereModel) {
171-
return WhereRenderer.withWhereModel(whereModel)
172-
.withRenderingContext(renderingContext)
173-
.build()
174-
.render();
170+
return whereModel.render(renderingContext);
175171
}
176172

177173
private Optional<FragmentAndParameters> calculateGroupByClause() {

‎src/main/java/org/mybatis/dynamic/sql/update/render/UpdateRenderer.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
import org.mybatis.dynamic.sql.util.FragmentCollector;
3434
import org.mybatis.dynamic.sql.util.Validator;
3535
import org.mybatis.dynamic.sql.where.WhereModel;
36-
import org.mybatis.dynamic.sql.where.render.WhereRenderer;
3736

3837
public class UpdateRenderer {
3938
private final UpdateModel updateModel;
@@ -104,10 +103,7 @@ private Optional<FragmentAndParameters> calculateWhereClause() {
104103
}
105104

106105
private Optional<FragmentAndParameters> renderWhereClause(WhereModel whereModel) {
107-
return WhereRenderer.withWhereModel(whereModel)
108-
.withRenderingContext(renderingContext)
109-
.build()
110-
.render();
106+
return whereModel.render(renderingContext);
111107
}
112108

113109
private Optional<FragmentAndParameters> calculateLimitClause() {

‎src/main/java/org/mybatis/dynamic/sql/where/WhereModel.java

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public boolean isNonRenderingClauseAllowed() {
5050
public Optional<WhereClauseProvider> render(RenderingStrategy renderingStrategy) {
5151
RenderingContext renderingContext = RenderingContext.withRenderingStrategy(renderingStrategy).build();
5252

53-
return render(renderingContext);
53+
return render(renderingContext).map(this::toWhereClauseProvider);
5454
}
5555

5656
public Optional<WhereClauseProvider> render(RenderingStrategy renderingStrategy,
@@ -60,7 +60,7 @@ public Optional<WhereClauseProvider> render(RenderingStrategy renderingStrategy,
6060
.withTableAliasCalculator(tableAliasCalculator)
6161
.build();
6262

63-
return render(renderingContext);
63+
return render(renderingContext).map(this::toWhereClauseProvider);
6464
}
6565

6666
public Optional<WhereClauseProvider> render(RenderingStrategy renderingStrategy, String parameterName) {
@@ -69,7 +69,7 @@ public Optional<WhereClauseProvider> render(RenderingStrategy renderingStrategy,
6969
.withParameterName(parameterName)
7070
.build();
7171

72-
return render(renderingContext);
72+
return render(renderingContext).map(this::toWhereClauseProvider);
7373
}
7474

7575
public Optional<WhereClauseProvider> render(RenderingStrategy renderingStrategy,
@@ -80,15 +80,14 @@ public Optional<WhereClauseProvider> render(RenderingStrategy renderingStrategy,
8080
.withParameterName(parameterName)
8181
.build();
8282

83-
return render(renderingContext);
83+
return render(renderingContext).map(this::toWhereClauseProvider);
8484
}
8585

86-
private Optional<WhereClauseProvider> render(RenderingContext renderingContext) {
86+
public Optional<FragmentAndParameters> render(RenderingContext renderingContext) {
8787
return WhereRenderer.withWhereModel(this)
8888
.withRenderingContext(renderingContext)
8989
.build()
90-
.render()
91-
.map(this::toWhereClauseProvider);
90+
.render();
9291
}
9392

9493
private WhereClauseProvider toWhereClauseProvider(FragmentAndParameters fragmentAndParameters) {

0 commit comments

Comments
 (0)