-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Implement ToSql for Box<str> #4617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@guissalustiano according to #4613 you might be missing some spots (: |
|
Yes it would be great to have it for the other |
|
Thanks for the return, I'll implement this! |
|
It is possible that PR #4610 will superseed this one as, following one of the PR change requests, I have added a blanket implementation for the |
|
I didn't see that, thanks @LucaCappelletti94 |
|
I suggest to not close this PR until @weiznich says so, as it is still possible that there are issues with my own PR. Still, I just thought it important to comment that the two PRs are in collision for the implementation of traits for the Box. |
|
#4610 is slightly different than this PR. With what's currently implemented in that other PR it should be possible to load/store values from any At least for So yes, literally the change in this PR is made obsolete by the other PR but there are similar features that might still be useful to add. |
I'm using Box to use less space on heap and would like to write it direct to the database with diesel