Skip to content

Improve documentation for Postgres loading modes #4764

@inklesspen

Description

@inklesspen

Rust Version

N/A

Diesel Version

N/A

Diesel Features

N/A

Database Version

N/A

Operating System Version

N/A

What happened?

The docs for PgConnection explain that diesel's Postgres support has two loading modes: default and row-by-row.

The explanation says (talking about the default mode) "Generally this mode will be more performant as it."

I suspect some words have been dropped from this explanation. I tried checking the commit history using git blame but it doesn't look like the full explanation was ever committed.

I am curious what the reason for the default mode's general performance superiority is, and how large a result set would have to be for row-by-row to be a good idea.

What did you expect to happen?

I expected to see a more complete explanation.

Additional details

No response

Steps to reproduce

Compile time error

No response

Checklist

  • I have already looked over the issue tracker and the discussion forum for similar possible closed issues.

  • This issue can be reproduced on Rust's stable channel. (Please submit the issue in the Rust issue tracker instead if that's not the case)

  • This issue can be reproduced without requiring a third party crate

Metadata

Metadata

Assignees

No one assigned

    Projects

    Status

    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions