Skip to content

Conversation

@scottsand-db
Copy link
Collaborator

@scottsand-db scottsand-db commented Oct 17, 2025

🥞 Stacked PR

Use this link to review incremental changes.


Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

How was this patch tested?

Does this PR introduce any user-facing changes?

* <p>Collects timing metrics for commit operations and generates reports for successful and failed
* commits.
*/
public class UcCommitTelemetry {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goal here is to be VERY succint -- I want the metrics collection and metrics result and the overall report to succinctly be in one class

@scottsand-db scottsand-db changed the title done first pass, no tests Oct 17, 2025
@scottsand-db scottsand-db marked this pull request as draft October 17, 2025 18:38
}

@SuppressWarnings("unchecked")
public <T, E extends Exception> T timeChecked(ThrowingSupplier<T, E> operation) throws E {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to be able to time a method that throws a checked exception E, without having to catch the aprent Exception type. See:

public static <T, E extends Exception> T timeCheckedOperation(

@scottsand-db scottsand-db force-pushed the stack/kernel_uc_committer_metrics branch from 93bb691 to 867bc5d Compare October 17, 2025 18:56
Copy link
Collaborator

@allisonport-db allisonport-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approach makes sense!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO -- Json Serialization tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants