Merge branch 'minor_polishing' of https://github.com/datahappy1/notes_app into main

� Conflicts:
�	notes_app/file.py

Author: Pavel.Prudky

notes_app/file.py

@@ -5,6 +5,15 @@
 SECTION_FILE_NAME_MINIMAL_CHAR_COUNT = 2
 
 
+def get_validated_file_path(file_path):
+    try:
+        with open(file=file_path, mode="r"):
+            pass
+    except (PermissionError, FileNotFoundError, IsADirectoryError):
+        return
+    return file_path
+
+
 class SectionIdentifier:
     def __init__(
         self, defaults, section_file_separator: str = None, section_name: str = None,
@@ -60,7 +69,7 @@ def get_validated_file_path(file_path):
             return
         return file_path
 
-    def _get_validated_raw_data(self, raw_data) -> str:
+    def _get_validated_raw_data(self, raw_data) -> AnyStr:
         matches = re.findall(
             self.defaults.DEFAULT_SECTION_FILE_SEPARATOR_REGEX, raw_data
         )

notes_app/view/notes_view.py

@@ -34,6 +34,7 @@
     AVAILABLE_SNACK_BAR_COLORS,
 )
 from notes_app.file import (
+    get_validated_file_path,
     File,
     SectionIdentifier,
     SECTION_FILE_NEW_SECTION_PLACEHOLDER,
@@ -380,7 +381,7 @@ def execute_open_file(self, file_path):
             self.show_error_bar(error_message="Invalid file")
             return
 
-        validated_file_path = File.get_validated_file_path(file_path)
+        validated_file_path = get_validated_file_path(file_path=file_path)
         if not validated_file_path:
             self.show_error_bar(error_message=f"Cannot open the file {file_path}")
             return

tests/test_unit_file.py

@@ -2,13 +2,21 @@
 
 import pytest
 
-from notes_app.file import File, SectionIdentifier
+from notes_app.file import SectionIdentifier, get_validated_file_path
 
 from notes_app.defaults import Defaults
 
 defaults = Defaults()
 
 
+def test_get_validated_file_path():
+    file_path = defaults.DEFAULT_NOTES_FILE_NAME
+    assert get_validated_file_path(file_path=file_path) == file_path
+
+    file_path = f"sample_not_existing_{uuid.uuid4().hex}.txt"
+    assert get_validated_file_path(file_path=file_path) is None
+
+
 class TestSectionIdentifier:
     def test_section_identifier(self):
         with pytest.raises(ValueError):
@@ -34,13 +42,6 @@ def test_section_identifier(self):
 
 
 class TestFile:
-    def test_get_validated_file_path(self):
-        file_path = defaults.DEFAULT_NOTES_FILE_NAME
-        assert File.get_validated_file_path(file_path=file_path) == file_path
-
-        file_path = f"sample_not_existing_{uuid.uuid4().hex}.txt"
-        assert File.get_validated_file_path(file_path=file_path) is None
-
     def test_get_raw_data_content(self, get_file):
         raw_data = get_file.get_raw_data_content()
         assert (